Add GraphQL Support#1
Merged
Merged
Conversation
TurtIeSocks
commented
Mar 10, 2021
TurtIeSocks
commented
Collaborator
- Remove Fetch requests
- Add graphql support
- React go brrr
- Remove Fetch requests - Add graphql support - react go brrr
jfberry
added a commit
to jfberry/ReactMap
that referenced
this pull request
Jul 20, 2026
The endpoint (in-memory) getAll paths filter rows with filterRTree, which returns true for empty area inputs — so unlike the SQL path's getAreaSql it did NOT deny a user who has no assigned areas while strictAreaRestrictions is on and restrictions are configured. Such a user received every fort in the viewport (access-control bypass). Add areaRestrictionsDenyAll (mirroring getAreaSql's strict-deny and empty-consolidated deny) and short-circuit each fort model's endpoint branch to [] before accepting rows. Addresses Mygod review comment WatWowMap#1 (P1). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.