Enable new Pokemon by default#382
Closed
Mygod wants to merge 1 commit into
Closed
Conversation
ok thanks
TurtIeSocks
requested changes
Feb 4, 2022
TurtIeSocks
left a comment
TurtIeSocks
left a comment
Collaborator
There was a problem hiding this comment.
Please test these changes as I don't think this is going to do what you think it will, thanks!
Collaborator
|
Closing due to inactivity. |
jfberry
added a commit
to jfberry/ReactMap
that referenced
this pull request
Jul 20, 2026
…pgap Golbat WatWowMap#382 now decodes TEMP_EVO_BRANCH_RESOURCE (reward type 20 — temp-evo branch = mega energy) into info.pokemon_id/amount, filling the generated quest_pokemon_id/quest_reward_amount columns exactly like a MEGA_RESOURCE (type 12) reward. So type 20 is now handled as mega everywhere: - SQL getAll: mega matching broadened to quest_reward_type IN (12, 20). - SQL getAvailable: queries.mega/megaAlt advertise (12, 20); type 20 excluded from the u<type> fallback set; megaBranchFallback machinery removed. - SQL search: a 'mega' reward-type search also matches type 20. - parseRdmRewards: any type-20 reward carrying info.pokemon_id is normalized to type 12 so the mega branch keys it as m<id>-<amount> (sourceQuestRewardType still preserves a u20 filter). - Endpoint DNF (buildPokestopDnfFilters): mega clauses emit quest_reward_type [12, 20] so Golbat returns type-20 mega stops. The empty-info GoFest 2026 Mewtwo stopgap (applyGoFest2026MewtwoRewardFallback + hardcoded m150-150) is retired — it required empty info and stops matching once Golbat WatWowMap#382 populates it. Requires deployed Golbat >= PR WatWowMap#382. Addresses Mygod review comment WatWowMap#3 (type-20 mega retrievability). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ok thanks