Refactoring#4
Merged
Merged
Conversation
TurtIeSocks
commented
Mar 12, 2021
TurtIeSocks
commented
Collaborator
- Move graphql to rootRouter
- Move settings to rootRouter
- Add dev options to config
- Add config options to front end
- Move graphql to rootRouter - Move settings to rootRouter - Add dev options to config - Add config options to front end
jfberry
added a commit
to jfberry/ReactMap
that referenced
this pull request
Jul 20, 2026
…resilience Three endpoint-source correctness fixes from the Mygod review: - WatWowMap#4 (P1): a pure-endpoint pokestop source now reports hasConfirmed:true. The Golbat scan always returns confirmed incident data, but no DB schema check runs for a knex-less source, so onlyConfirmed and confirmed rocket-reward (a) filters were silently degrading to the grunt possible-encounter pool. - WatWowMap#6 (P2): historicalRarity now skips only pure-endpoint sources (no bound knex), not dual sources. Testing source.mem alone dropped a dual source DB and cleared the historical rarity map on every refresh. - WatWowMap#8 (P2): DbManager.getOne uses Promise.allSettled so a pure-endpoint source whose by-id fetch misses (falling through to an unbound this.query() that throws) no longer fails the whole single-fort lookup. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.