Refactor crop generation module as subpackage to avoid single module expanding indefinitely with added features#32
Merged
Conversation
…ated as a subpackage, moved crop generator protocol to its own stand aloen module and center and point-centered crop generator functions in their respective modules under the new subpackage.
… the full FOV best effort
…ubpackage while supporting older import signatures for compatibility
MikeLippincott
approved these changes
Jul 20, 2026
MikeLippincott
left a comment
MikeLippincott
left a comment
Member
There was a problem hiding this comment.
LGTM! Good PR. Please let me know if any of my comments/questions do not make sense.
Last thing here that should probably be added in this PR or another PR are tests for these functions/classes! Do they behave how you expect them to?
…and summary reporting for center, point-centered, and tile crops.
…explanation on non-overlapping tile benefits for convolutional neural networks.
…opGenerator type directly
Collaborator
Author
|
Added tests. |
Collaborator
Author
|
@MikeLippincott thanks for the review. Addressed all your comments. Merging now! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original
src/virtual_stain_flow/datasets/ds_engine/crop_generator.pyhouses the protocol and two types of crop generating function. As more functionalities are added the single module would expand making it hard to read and maintain. So I decided to refactor the crop generation module as a sub package. Also added a new tiling crop generator.