Merged
Conversation
When annotate is loaded on non-GLES renderer, it will not initialize the overlay array. So when we iterate at the end, it will crash as the array is empty. Instead, we can iterate over all the elements in the array. This way, it works also for empty arrays :) In addition I also removed a few of the .reset() calls. They are not necessary, as the memory will be freed automatically by the smart pointers (shared_ptrs, unique_ptrs).
Member
|
LGTM! Feel free to merge when it's ready. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When annotate is loaded on non-GLES renderer, it will not initialize the
overlay array. So when we iterate at the end, it will crash as the array
is empty. Instead, we can iterate over all the elements in the array.
This way, it works also for empty arrays :)
In addition I also removed a few of the .reset() calls. They are not
necessary, as the memory will be freed automatically by the smart
pointers (shared_ptrs, unique_ptrs).