Skip to content

showrepaint: use new render-agnostic APIs in core#282

Merged
soreau merged 1 commit intomasterfrom
update-showrepaint
Jul 22, 2025
Merged

showrepaint: use new render-agnostic APIs in core#282
soreau merged 1 commit intomasterfrom
update-showrepaint

Conversation

@ammen99
Copy link
Member

@ammen99 ammen99 commented Jul 12, 2025

Requires some APIs I will push together with the wlroots 0.19 release, so don't merge yet :)

@ammen99 ammen99 force-pushed the update-showrepaint branch from c426e57 to c1bed08 Compare July 12, 2025 13:51
@ammen99 ammen99 marked this pull request as ready for review July 20, 2025 08:52
@soreau
Copy link
Member

soreau commented Jul 22, 2025

Requires some APIs I will push together with the wlroots 0.19 release, so don't merge yet :)

Track wlroots 0.19 has been merged, is this good to merge now too?

@ammen99
Copy link
Member Author

ammen99 commented Jul 22, 2025

Requires some APIs I will push together with the wlroots 0.19 release, so don't merge yet :)

Track wlroots 0.19 has been merged, is this good to merge now too?

Yes, that's why I marked it as ready for review.

@soreau
Copy link
Member

soreau commented Jul 22, 2025

The only question I have is, what do these changes do differently than the current show-repaint? Both seem to work pretty much the same, as far as I could tell. Aside from that, I approve of the changes because I trust it is for the better.

@ammen99
Copy link
Member Author

ammen99 commented Jul 22, 2025

The PR should ideally change nothing in the behavior of the plugin. But it uses render-agnostic APIs so it should work with the vulkan and pixman renderers too.

@soreau
Copy link
Member

soreau commented Jul 22, 2025

The PR should ideally change nothing in the behavior of the plugin. But it uses render-agnostic APIs so it should work with the vulkan and pixman renderers too.

I see now, thanks for explaining and thanks for the PR!

@soreau soreau merged commit 4bc574f into master Jul 22, 2025
8 of 12 checks passed
@ammen99 ammen99 deleted the update-showrepaint branch July 22, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants