chore: remove deprecated redis call#48
Open
aristotelesbr wants to merge 4 commits intoWeTransfer:masterfrom
Open
chore: remove deprecated redis call#48aristotelesbr wants to merge 4 commits intoWeTransfer:masterfrom
aristotelesbr wants to merge 4 commits intoWeTransfer:masterfrom
Conversation
This Lua command was required for Redis < 5.0 to enable effects replication\nin scripts that mix reads and writes. Since Redis 5.0 this is the default\nbehavior. The call is a no-op in Redis 5/6/7.0, deprecated in 7.1, and\nerrors in Redis 7.2+.
Same change as the previous commit, applied to the throttle Lua script.\nRequired for Redis 7.2+ compatibility.
redis gem 2.x (last release 2015) and 3.x (last release 2018) are\nno longer maintained. The new floor aligns with the implicit Redis\nserver 5.0+ requirement after removing replicate_commands().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the
redis.replicate_commands()call from the Lua scripts to ensure compatibility with newer Redis versions.This function was originally required to enable effects replication, but since Redis 5.0 this behavior is already the default. It later became deprecated in Redis 7.0, and can now cause errors in more recent releases like 7.2+.
Removing it does not change the behavior for supported Redis versions (≥ 5.0), but prevents issues when running on newer versions.