Reorder results of fd_permissions_set in ephemeral#216
Closed
ueno wants to merge 1 commit into
Closed
Conversation
This makes sure that the first result is an errno as generate-raw expects: https://github.com/bytecodealliance/wasi/blob/master/crates/generate-raw/src/lib.rs#L280
Contributor
|
I think the issue is that this is supposed to be an input parameter. See #213 |
Author
|
Ah, indeed. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried to feed the current ephemeral witx files to the
generate-rawtool and noticed a minor inconsistency. Unlike other interface functions,permissions_setinwasi_ephemeral_fd.witxreturnserroras the second result, which is not supported by the tool:https://github.com/bytecodealliance/wasi/blob/master/crates/generate-raw/src/lib.rs#L280
Might it make sense to change the order to be consistent with the other part of the proposal?