Skip to content

Release version 123 - #7394

Merged
kripken merged 5 commits into
WebAssembly:mainfrom
kripken:version_123
Mar 25, 2025
Merged

Release version 123#7394
kripken merged 5 commits into
WebAssembly:mainfrom
kripken:version_123

Conversation

@kripken

@kripken kripken commented Mar 24, 2025

Copy link
Copy Markdown
Member

Given the big speedup in our official release binaries for Linux, this seems
useful to get to users quickly.

@kripken
kripken requested a review from tlively March 24, 2025 22:24
@tlively

tlively commented Mar 24, 2025

Copy link
Copy Markdown
Member

I wonder if we should revert #7371 before releasing to minimize the chance of getting bug reports from people using --all-features when their binaries suddenly contain exact references. OTOH, this would just delay the problem by one release, so it might not be beneficial enough.

@kripken

kripken commented Mar 24, 2025

Copy link
Copy Markdown
Member Author

Interesting, yeah, I was thinking about this too. It does seem like -all is "risky" since it enables all the things, which can change, just like enabling all warnings in a compiler. So this annoyance for users seems unavoidable, and a delay won't change much.

The only vague idea I had was maybe to have some -all vs -all-experimental where the latter enables early-stage features. But I'm not sure I like that, or know how to really distinguish the groups.

If we want to consider some idea like that, or some other way to avoid the problem, then maybe let's revert that before the release. If that doesn't seem promising I'm happy to drop it. What do you think?

@tlively tlively left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, let's maybe just bite the bullet and make the release with the current behavior. Maybe let's add a warning like this in the changelog.

Comment thread CHANGELOG.md
@kripken

kripken commented Mar 25, 2025

Copy link
Copy Markdown
Member Author

Makes sense, thanks. I rewrote the comment a bit to add a suggestion for what to do, PTAL.

@tlively tlively left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kripken
kripken merged commit 6a6e080 into WebAssembly:main Mar 25, 2025
@kripken
kripken deleted the version_123 branch March 25, 2025 18:13
sbc100 added a commit to sbc100/emscripten that referenced this pull request Mar 25, 2025
sbc100 added a commit to emscripten-core/emscripten that referenced this pull request Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants