Skip to content

[wasm-split] Validate output modules when custom-descriptor is enabled #8772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aheejin wants to merge 2 commits into
base: main
Choose a base branch
from
+13 −1
Open

[wasm-split] Validate output modules when custom-descriptor is enabled #8772

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2112b05
[wasm-split] Validate output modules
aheejin May 15, 2026
6f63abe
Enable validation only when custom-desriptor is enabled
aheejin May 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/tools/wasm-split/wasm-split.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,8 @@ void parseInput(Module& wasm, const WasmSplitOptions& options) {

options.applyOptionsAfterParse(wasm);

if (options.passOptions.validate && !WasmValidator().validate(wasm)) {
if (options.passOptions.validate &&
!WasmValidator().validate(wasm, options.passOptions)) {
Fatal() << "error validating input";
}
}
Expand Down Expand Up @@ -100,6 +101,17 @@ void writeModule(Module& wasm,
runner.add("strip-debug");
runner.run();
}

// We currently cannot enable validation for outputs when custom-descriptors
// is not enabled. See the description of
// https://github.com/WebAssembly/binaryen/pull/8043.
// TODO Fix this and enable validation for all cases.
if (options.passOptions.validate &&
!WasmValidator().validate(wasm, options.passOptions) &&
wasm.features.hasCustomDescriptors()) {
Fatal() << "error validating output module";
}

ModuleWriter writer(options.passOptions);
writer.setBinary(options.emitBinary);
writer.setDebugInfo(options.passOptions.debugInfo && !options.stripDebug);
Expand Down
Loading