Validate natural alignment for atomic memory operations - #8966
Open
ANAMASGARD wants to merge 1 commit into
Open
Conversation
Preserve memarg alignment in IR for atomic load/store/RMW/cmpxchg/wait/notify (including field delegations) so non-natural alignment fails validation. Fixes WebAssembly#8962 Signed-off-by: Gaurav Chaudhary <chaudharygaurav2004@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8962
Atomic memory instructions were parsing
memargalignment but not keeping it in the IR for RMW, cmpxchg, wait, and notify. The builder also forced natural alignment, so invalid alignment from WAT or binary input was silently normalized and passed validation.The threads proposal requires atomic accesses to use natural alignment (see WebAssembly/threads#242). Binaryen should reject invalid modules rather than accept them.
This PR stores
alignon all atomic memory IR nodes, threads it through WAT/binary parsing and printing, and validates it centrally via the existingvalidateAlignment(..., isAtomic=true)check. The DeAlign pass skips atomic load/store so it does not rewrite their alignment. Adds lit tests and unskipsthreads/atomic.wast.Test plan
test/lit/validation/atomic-alignment.wasttest/lit/passes/dealign-atomics.wastthreads/atomic.wast(unskipped)