This repository was archived by the owner on Nov 3, 2021. It is now read-only.
Fix variable names in memory.init execution#141
Open
fitzgen wants to merge 1 commit into
Open
Conversation
The values popped from the stack were named `cnt`, `src`, and `dst` but then later referred to as `n`, `s`, and `d` respectively. I've updated all uses to the names given when popped from the stack.
Member
|
I think @rossberg preferred the single letter names; in particular, ISTR without them you need to bracket the letters (or they'll be interpreted as implicit multiplication). In any case, these are the only places in the file where |
Contributor
|
https://webassembly.github.io/bulk-memory-operations/core/exec/instructions.html#exec-memory-init is currently inconsistent. Looks like someone needs to make a convicing call which names to use. |
Member
|
@nomeata, the spec doc on this proposal is inconsistent in a number of ways, due to its circular dependency with the reference types proposal. This should be rectified in the ref types spec draft, which includes this one (at some point backporting clean-ups became too much effort). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The values popped from the stack were named
cnt,src, anddstbut then later referred to asn,s, anddrespectively. I've updated all uses to the names given when popped from the stack.