You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The cmake_build_type is wrongly spelled. When cmake receives as an invalid cmake_build_type, it won't add optimization flags such as -O2 to compiler command. Then the complication is unoptimized.
The reason will be displayed to describe this comment to others. Learn more.
Good catch! I confirmed from the CMake docs that this is the right change and searched through the Makefile to check that there were no other typos of this kind.
@abrown
I found the abort.c CI error which blocks recent PRs is not difficult to fix.
The problem is just the wasmtime is updated the 19.0.0 but the wasi_snapshot_preview1.command.wasm is still 16.0.0, which leads to the version mismatch. Since the wasm time is installed by --version dev, the wasi_snapshot_preview1.command.wasm can also be downloaded from the "dev" release. Then the problem can be solved.
The checks already passed locally on my machine. Could you help to rerun the CI?
@Changqing-JING thanks for the reminder to look at this again and good find on the adapter incompatibility! I thought it was something related to that from a recent wasi-libc PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cmake_build_type is wrongly spelled. When cmake receives as an invalid cmake_build_type, it won't add optimization flags such as
-O2to compiler command. Then the complication is unoptimized.