exclude 32-bit Windows artifact in download-workflow-artifacts.sh#417
Merged
abrown merged 1 commit intoWebAssembly:mainfrom May 9, 2024
Merged
exclude 32-bit Windows artifact in download-workflow-artifacts.sh#417abrown merged 1 commit intoWebAssembly:mainfrom
abrown merged 1 commit intoWebAssembly:mainfrom
Conversation
This helps ensure the identically-named 32-bit tarfile doesn't overwrite the 64-bit one when we extract everything into a single directory. I'll follow this up by making an updated wasi-sdk-22.0.m-mingw.tar.gz and adding it to the wasi-sdk-22 release. Fixes WebAssembly#326 Signed-off-by: Joel Dice <joel.dice@fermyon.com>
alexcrichton
approved these changes
May 9, 2024
Collaborator
|
At Joel's request I downloaded the artifacts from the wasi-sdk-22 CI run, verified that the x86 one matched the current mingw artifact, and then uploaded the x64 one under the name "mingw64". That should get a published binary for the wasi-sdk-22 release but in the future it'll just be the normal "mingw" release |
abrown
approved these changes
May 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This helps ensure the identically-named 32-bit tarfile doesn't overwrite the 64-bit one when we extract everything into a single directory.
I'll follow this up by making an updated wasi-sdk-22.0.m-mingw.tar.gz and adding it to the wasi-sdk-22 release.
Fixes #326