Skip to content

Use NotAllowedError instead of SecurityError#267

Merged
mjwilson-google merged 1 commit intoWebAudio:gh-pagesfrom
mjwilson-google:not-allowed-error
Sep 5, 2024
Merged

Use NotAllowedError instead of SecurityError#267
mjwilson-google merged 1 commit intoWebAudio:gh-pagesfrom
mjwilson-google:not-allowed-error

Conversation

@mjwilson-google
Copy link
Copy Markdown
Contributor

This is to fix #261

@mjwilson-google mjwilson-google self-assigned this Sep 4, 2024
@mjwilson-google mjwilson-google removed their assignment Sep 4, 2024
@mjwilson-google
Copy link
Copy Markdown
Contributor Author

Paul, please take a look since this will affect the implementations.

@mjwilson-google mjwilson-google merged commit 3c36dcb into WebAudio:gh-pages Sep 5, 2024
@mjwilson-google mjwilson-google deleted the not-allowed-error branch September 5, 2024 17:39
sideshowbarker pushed a commit to mdn/content that referenced this pull request Nov 16, 2025
nikelborm added a commit to nikelborm/firefox that referenced this pull request Dec 19, 2025
…d `SecurityError` and `InvalidAccessError` in favor of `NotAllowedError` r?gsvelto,bholley

= `InvalidAccessError` replaced by `NotAllowedError`:

The change in spec: [WebAudio/web-midi-api@3795f22](WebAudio/web-midi-api@3795f22)
According PR: [WebAudio/web-midi-api#278](WebAudio/web-midi-api#278)
MDN update PR: [mdn/content#42334](mdn/content#42334)

== Affected APIs

1. `.send` method of output MIDI ports
2. `.open` method of MIDI ports

= `SecurityError` replaced by `NotAllowedError`:

The change in spec: [WebAudio/web-midi-api@b7806b8](WebAudio/web-midi-api@b7806b8)
According PR: [WebAudio/web-midi-api#267](WebAudio/web-midi-api#267)
MDN update PR: [mdn/content#41956](mdn/content#41956)

== Affected APIs

1. `navigator.requestMIDIAccess` method
@nikelborm
Copy link
Copy Markdown
Contributor

nikelborm commented Dec 19, 2025

nikelborm added a commit to nikelborm/firefox that referenced this pull request Dec 25, 2025
…d `SecurityError` and `InvalidAccessError` in favor of `NotAllowedError` r?gsvelto

= `InvalidAccessError` replaced by `NotAllowedError`:

The change in spec: [WebAudio/web-midi-api@3795f22](WebAudio/web-midi-api@3795f22)
According PR: [WebAudio/web-midi-api#278](WebAudio/web-midi-api#278)
MDN update PR: [mdn/content#42334](mdn/content#42334)

== Affected APIs

1. `.send` method of output MIDI ports
2. `.open` method of MIDI ports

= `SecurityError` replaced by `NotAllowedError`:

The change in spec: [WebAudio/web-midi-api@b7806b8](WebAudio/web-midi-api@b7806b8)
According PR: [WebAudio/web-midi-api#267](WebAudio/web-midi-api#267)
MDN update PR: [mdn/content#41956](mdn/content#41956)

== Affected APIs

1. `navigator.requestMIDIAccess` method
nikelborm added a commit to nikelborm/firefox that referenced this pull request Dec 25, 2025
…d `SecurityError` and `InvalidAccessError` in favor of `NotAllowedError` r?gsvelto

= `InvalidAccessError` replaced by `NotAllowedError`:

The change in spec: [WebAudio/web-midi-api@3795f22](WebAudio/web-midi-api@3795f22)
According PR: [WebAudio/web-midi-api#278](WebAudio/web-midi-api#278)
MDN update PR: [mdn/content#42334](mdn/content#42334)

== Affected APIs

1. `.send` method of output MIDI ports
2. `.open` method of MIDI ports

= `SecurityError` replaced by `NotAllowedError`:

The change in spec: [WebAudio/web-midi-api@b7806b8](WebAudio/web-midi-api@b7806b8)
According PR: [WebAudio/web-midi-api#267](WebAudio/web-midi-api#267)
MDN update PR: [mdn/content#41956](mdn/content#41956)

== Affected APIs

1. `navigator.requestMIDIAccess` method
nikelborm added a commit to nikelborm/firefox that referenced this pull request Dec 25, 2025
…d `SecurityError` and `InvalidAccessError` in favor of `NotAllowedError` r=gsvelto

= `InvalidAccessError` replaced by `NotAllowedError`:

The change in spec: [WebAudio/web-midi-api@3795f22](WebAudio/web-midi-api@3795f22)
According PR: [WebAudio/web-midi-api#278](WebAudio/web-midi-api#278)
MDN update PR: [mdn/content#42334](mdn/content#42334)

== Affected APIs

1. `.send` method of output MIDI ports
2. `.open` method of MIDI ports

= `SecurityError` replaced by `NotAllowedError`:

The change in spec: [WebAudio/web-midi-api@b7806b8](WebAudio/web-midi-api@b7806b8)
According PR: [WebAudio/web-midi-api#267](WebAudio/web-midi-api#267)
MDN update PR: [mdn/content#41956](mdn/content#41956)

== Affected APIs

1. `navigator.requestMIDIAccess` method
nikelborm added a commit to nikelborm/firefox that referenced this pull request Dec 25, 2025
…d `SecurityError` and `InvalidAccessError` in favor of `NotAllowedError` r=gsvelto

= `InvalidAccessError` replaced by `NotAllowedError`:

The change in spec: [WebAudio/web-midi-api@3795f22](WebAudio/web-midi-api@3795f22)
According PR: [WebAudio/web-midi-api#278](WebAudio/web-midi-api#278)
MDN update PR: [mdn/content#42334](mdn/content#42334)

== Affected APIs

1. `.send` method of output MIDI ports
2. `.open` method of MIDI ports

= `SecurityError` replaced by `NotAllowedError`:

The change in spec: [WebAudio/web-midi-api@b7806b8](WebAudio/web-midi-api@b7806b8)
According PR: [WebAudio/web-midi-api#267](WebAudio/web-midi-api#267)
MDN update PR: [mdn/content#41956](mdn/content#41956)

== Affected APIs

1. `navigator.requestMIDIAccess` method

Differential Revision: https://phabricator.services.mozilla.com/D277533
nikelborm added a commit to nikelborm/firefox that referenced this pull request Dec 25, 2025
…d `SecurityError` and `InvalidAccessError` in favor of `NotAllowedError` r=gsvelto

= `InvalidAccessError` replaced by `NotAllowedError`:

The change in spec: [WebAudio/web-midi-api@3795f22](WebAudio/web-midi-api@3795f22)
According PR: [WebAudio/web-midi-api#278](WebAudio/web-midi-api#278)
MDN update PR: [mdn/content#42334](mdn/content#42334)

== Affected APIs

1. `.send` method of output MIDI ports
2. `.open` method of MIDI ports

= `SecurityError` replaced by `NotAllowedError`:

The change in spec: [WebAudio/web-midi-api@b7806b8](WebAudio/web-midi-api@b7806b8)
According PR: [WebAudio/web-midi-api#267](WebAudio/web-midi-api#267)
MDN update PR: [mdn/content#41956](mdn/content#41956)

== Affected APIs

1. `navigator.requestMIDIAccess` method

Differential Revision: https://phabricator.services.mozilla.com/D277533
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rejecting the MIDI permission should use NotAllowedError, not SecurityError

3 participants