to main - #1012
Merged
Merged
Conversation
JaMmusic#1250 — a 29-pitch batch silently skipped 6 venues with no venueType/templateOverride/templateType because resolvePitch hard-400'd instead of sending, and the skip report showed only Mongo ObjectIds so Josh couldn't tell which venues failed. - resolvePitch now falls back to DEFAULT_TEMPLATE_TYPE (MidRangeCafeBar, per Josh's decision on the issue) instead of erroring when templateType/templateOverride/venueType all resolve empty. The "no active template" guard still fails hard if even the default is missing/inactive. - Every sendBatch skipped entry now carries venueName (never omitted; '(unknown venue)' when no venue doc could be loaded at all). Bumps patch version 2.10.1 -> 2.10.2. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
JaMmusic#1250 — extends outreach-controller.spec.ts with: - a venue with no templateType/templateOverride/venueType now resolves to DEFAULT_TEMPLATE_TYPE and sends instead of being skipped - an explicit templateType, and venue.venueType, both still win over the default fallback (precedence guardrails) - every sendBatch skipped entry carries venueName, including the UNKNOWN_VENUE_NAME placeholder when no venue doc could be loaded Full `npm test` (eslint + jscpd + typecheck + vitest --coverage) green: 933/933 tests passing. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…-fallback should not skip should use a default template and send, please fix !!!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.