Skip to content

Add deep argument to the type of cloneNode()#222

Merged
WebReflection merged 1 commit into
WebReflection:mainfrom
tai2:add-deep-argument-to-clone-node
Oct 22, 2023
Merged

Add deep argument to the type of cloneNode()#222
WebReflection merged 1 commit into
WebReflection:mainfrom
tai2:add-deep-argument-to-clone-node

Conversation

@tai2
Copy link
Copy Markdown
Contributor

@tai2 tai2 commented Oct 7, 2023

Node's cloneNode() should take the deep argument in type definition. Otherwise, other derived classes like Element also cannot take that parameter in TS.

@WebReflection
Copy link
Copy Markdown
Owner

to be honest, I am not sure this is a TS shenanigan but cloneNode already takes an optional argument ... I'll merge it, let's hope it will stay around ... if it doesn't, I am afraid I need to change the signature in the code, not in its .d.ts definition.

@WebReflection WebReflection merged commit 94434f7 into WebReflection:main Oct 22, 2023
@WebReflection WebReflection mentioned this pull request Oct 22, 2023
@tai2 tai2 deleted the add-deep-argument-to-clone-node branch October 23, 2023 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants