Merged
Conversation
Sohn123
approved these changes
Apr 11, 2023
Member
Sohn123
left a comment
Sohn123
left a comment
There was a problem hiding this comment.
Looks good to me. Nice that you added some new tests 🚀 I'll add a new tag for the new version.
linaScience
pushed a commit
that referenced
this pull request
Jul 14, 2023
* Implement min_vni configuration option * Format * Lint * Format * Lint * Format
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
min_vnioption. Closes #56.It also improves test isolation by adding a static
resetmethod to theConfigurationsingleton so tests can start with a fresh configuration.