Adding user-agent option#337
Merged
mwrock merged 2 commits intoWinRb:masterfrom Apr 26, 2022
laxa:add_user_agent_option
Merged
Conversation
mwrock
approved these changes
Apr 26, 2022
Member
|
This looks good. Thanks! |
Contributor
Author
|
Thanks for the merge. Do you have any idea when a new release would be made? I introduced this PR to use it in another project that depends on WinRM. Cheers, |
Contributor
Author
|
Hello sir, I am wondering if that would be possible to make a release including this fix and to push it on the gem so other projects can use it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the issue #336.
It should be noted that there is a slight change regarding the
User-Agentwith this PR. Before the changement the User-Agent would have been:After this PR, the
User-Agentwould simply be:Ruby WinRM Client.As I am nowhere near the skill of a ruby developer, let me know if my code can be improved (I have run the required tests).