fix(client): include public DataMap in upload payment#121
Merged
jacderida merged 1 commit intoJun 16, 2026
Conversation
Store public upload DataMaps through the same file upload chunk set so wave and merkle payments cover the shareable DataMap address instead of paying for it in a second post-upload call. SemVer: bug fix; no public ant-client API break expected.
jacderida
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Public file uploads now include the serialized
DataMapin the same upload chunk set before payment selection. This means both wave-batch and merkle payment paths pay for the shareable public DataMap address as part of the upload, instead of uploading the file body first and then doing a separatedata_map_storepayment.The CLI
ant file upload --publicnow uses this public upload path directly and reports the returneddata_map_addressfrom the batch-paid upload result.Why
Previously the direct CLI public upload path paid for file chunks first, then stored the public DataMap in a second payment/store step. That made public uploads inconsistent with the external-signer prepare path and left the DataMap outside the intended batch payment.
SemVer
Bug fix; no public ant-client API break expected.
Validation
cargo fmt --all -- --checkgit diff --checkcargo clippy --all-targets --all-features -- -D warningscargo test -p ant-core --test e2e_file test_public_file_upload_direct_batches_datamap --features devnet -- --nocapturecargo test -p ant-cli