fix: upload SNP chunks to initial witness group#122
Merged
Conversation
jacderida
approved these changes
Jun 16, 2026
dirvine
force-pushed
the
fix/snp-put-initial-witness-close-group
branch
from
June 16, 2026 18:01
a9dba3b to
333082a
Compare
Contributor
Author
|
Updated per Mick's follow-up:
Re-verified locally:
|
dirvine
force-pushed
the
fix/snp-put-initial-witness-close-group
branch
from
June 16, 2026 18:06
333082a to
393d083
Compare
This was referenced Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The receiver-side gate in
ant-nodeis intentionally strict: a node should only accept storage for chunks it considers itself responsible for. The client was collecting quotes from the witnessed consensus set and then uploading to that quoted set. Under NAT/reachability divergence, that can select peers outside the initial responsible close group and hit receiver-gate rejections.This PR keeps the quote group unchanged, as requested, but aligns the actual PUT targets with the initial/witness close group.
Verification
cargo test -p ant-core --lib data::client::quote -- --nocapturecargo check -p ant-corecargo fmt --all -- --checkgit diff --check