Skip to content

fix: upload SNP chunks to initial witness group#122

Merged
jacderida merged 1 commit into
rc-2026.6.2from
fix/snp-put-initial-witness-close-group
Jun 16, 2026
Merged

fix: upload SNP chunks to initial witness group#122
jacderida merged 1 commit into
rc-2026.6.2from
fix/snp-put-initial-witness-close-group

Conversation

@dirvine

@dirvine dirvine commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Keep SNP quote collection on the quorum-witnessed candidate set.
  • Change SNP PUT targets to the initial witnessed close group instead of the witnessed/quoted set.
  • Preserve median-issuer voter ordering so the initial PUT wave prefers witnesses that voted for the paid median issuer.

Why

The receiver-side gate in ant-node is intentionally strict: a node should only accept storage for chunks it considers itself responsible for. The client was collecting quotes from the witnessed consensus set and then uploading to that quoted set. Under NAT/reachability divergence, that can select peers outside the initial responsible close group and hit receiver-gate rejections.

This PR keeps the quote group unchanged, as requested, but aligns the actual PUT targets with the initial/witness close group.

Verification

  • cargo test -p ant-core --lib data::client::quote -- --nocapture
  • cargo check -p ant-core
  • cargo fmt --all -- --check
  • git diff --check

@dirvine
dirvine force-pushed the fix/snp-put-initial-witness-close-group branch from a9dba3b to 333082a Compare June 16, 2026 18:01
@dirvine

dirvine commented Jun 16, 2026

Copy link
Copy Markdown
Contributor Author

Updated per Mick's follow-up:

  • Witnessed candidates are now sorted by XOR closeness as the primary sort before quote collection.
  • SNP quote collection now tries the closest CLOSE_GROUP_SIZE witnessed peers first and only falls back to further witnessed peers if a closer peer fails to provide a usable quote.
  • Merkle/fault-tolerant quote preflight keeps the previous concurrent over-query behaviour.

Re-verified locally:

  • cargo test -p ant-core --lib data::client::quote -- --nocapture — 23 passed
  • cargo check -p ant-core
  • cargo fmt --all -- --check
  • git diff --check

@dirvine
dirvine force-pushed the fix/snp-put-initial-witness-close-group branch from 333082a to 393d083 Compare June 16, 2026 18:06
@jacderida
jacderida merged commit dcaca42 into rc-2026.6.2 Jun 16, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants