Migrate from saorsa-node to ant-node 0.6#3
Merged
Conversation
Migrate from the saorsa-node git dependency to the published ant-node 0.6 crate. Updates all imports, binary resolution constants, API call sites (new peer_addrs parameter), and comments/strings throughout. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Thread MultiAddr from DHT lookups through the entire request pipeline so send_and_await_chunk_response can establish faster connections. Network::find_closest_peers now returns (PeerId, Vec<MultiAddr>) instead of discarding the addresses from DHTNode. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Simplify handler logic by replacing handle_message with try_handle_request. Add explicit handling for non-request messages and improve error messaging.
jacderida
approved these changes
Mar 25, 2026
4 tasks
Nic-dorman
added a commit
that referenced
this pull request
Jun 9, 2026
- TempDownload RAII guard: removes the staging file on every disk-path error AND on a panic unwind out of the block_in_place decrypt loop, replacing three duplicated cleanup arms (#1). drop(file) before rename for Windows. - New Error::Cancelled variant for a dropped receiver; was misclassified as Error::Network (#3). Routed to ApplicationError in classify_error so caller-initiated cancellation is not retried as a transport failure. - Doc the exact channel item type Result<Bytes, Error> on file_download_to_sender (#4). - Drop now-stale #[allow(clippy::unused_async)] on file_download (#7). - Harden e2e test: assert each streamed chunk is non-empty and >=2 segments arrive (multi-batch property), rename to test_file_download_to_sender_multibatch_round_trip (#6). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Nic-dorman
added a commit
that referenced
this pull request
Jun 11, 2026
- TempDownload RAII guard: removes the staging file on every disk-path error AND on a panic unwind out of the block_in_place decrypt loop, replacing three duplicated cleanup arms (#1). drop(file) before rename for Windows. - New Error::Cancelled variant for a dropped receiver; was misclassified as Error::Network (#3). Routed to ApplicationError in classify_error so caller-initiated cancellation is not retried as a transport failure. - Doc the exact channel item type Result<Bytes, Error> on file_download_to_sender (#4). - Drop now-stale #[allow(clippy::unused_async)] on file_download (#7). - Harden e2e test: assert each streamed chunk is non-empty and >=2 segments arrive (multi-batch property), rename to test_file_download_to_sender_multibatch_round_trip (#6). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
saorsa-nodegit dependency withant-node = "0.6"from crates.io — updates all imports (saorsa_node::→ant_node::), binary resolution constants, comments, and test strings across 22 files.send_and_await_chunk_response—Network::find_closest_peersnow returns(PeerId, Vec<MultiAddr>)instead of discardingDHTNode.addresses, enabling faster P2P connections at all 4 call sites.Test plan
cargo checkpassescargo fmt --all -- --checkcleancargo clippy --all-targets --all-features -- -D warningsclean🤖 Generated with Claude Code