Skip to content

fix(payment): widen paid-quote issuer admission to close group + margin #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jacderida merged 1 commit into from
Jun 12, 2026
Merged

fix(payment): widen paid-quote issuer admission to close group + margin #139

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions src/payment/verifier.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ use crate::payment::pricing::{calculate_price, derive_records_stored_from_price}
use crate::payment::proof::{
deserialize_merkle_proof, deserialize_proof, detect_proof_type, ProofType,
};
use crate::replication::config::storage_admission_width;
use crate::storage::lmdb::LmdbStorage;
use ant_protocol::payment::verify::{verify_quote_content, verify_quote_signature};
use evmlib::common::{Amount, QuoteHash};
Expand Down Expand Up @@ -919,17 +920,27 @@ impl PaymentVerifier {
}
};

let close_group_size = self.config.close_group_size;
// Verify against the close group PLUS the storage-admission margin
// rather than the bare configured close-group width. The check compares
// the client's network-derived quote set against this node's *local*
// routing-table view, which on a real (young / large / NAT-heavy)
// network does not perfectly reflect the global K-closest: a peer the
// client legitimately quoted routinely ranks just outside this node's
// local close-group window. Bare `close_group_size` (no margin) falsely
// rejects those honest payments — the same divergence the sibling
// receiver admission check absorbs via `storage_admission_width`
// (PR #137); apply the same margin here for symmetry.
let admission_width = storage_admission_width(self.config.close_group_size);
let closest = p2p_node
.dht_manager()
.find_closest_nodes_local_with_self(xorname, close_group_size)
.find_closest_nodes_local_with_self(xorname, admission_width)
.await;
if closest.iter().any(|node| node.peer_id == *issuer_peer_id) {
return Ok(());
}

Err(Error::Payment(format!(
"Paid quote issuer {} is not among this node's local {close_group_size} closest peers for {}",
"Paid quote issuer {} is not among this node's local {admission_width} closest peers for {}",
issuer_peer_id.to_hex(),
hex::encode(xorname)
)))
Expand Down
Loading