feat(antd-py): gRPC external-signer prepare/finalize parity with REST - #143
Closed
Nic-dorman wants to merge 1 commit into
Closed
Conversation
Replaces the three `NotImplementedError` stubs on `GrpcClient` / `AsyncGrpcClient` for `prepare_upload` / `prepare_data_upload` / `finalize_upload` with real implementations, and adds four new methods mirroring the REST client surface: * `prepare_upload(path, visibility=None)` + `prepare_upload_public(path)` * `prepare_data_upload(data, visibility=None)` * `finalize_upload(upload_id, tx_hashes)` (wave-batch) * `finalize_merkle_upload(upload_id, winner_pool_hash, store_data_map=False)` * `prepare_chunk_upload(data)` (new, no prior stub) * `finalize_chunk_upload(upload_id, tx_hashes) -> str` (new) Sync + async parity (14 method impls total). Wallet stubs (`wallet_address` / `wallet_balance` / `wallet_approve`) are out of scope here — they belong to the separate WalletService-over-gRPC work and will land in a follow-up. Proto regen: * `python scripts/generate_proto.py` regenerated all stubs under `src/antd/_proto/antd/v1/`. New `upload_pb2.py` / `upload_pb2.pyi` / `upload_pb2_grpc.py`. `chunks_pb2.*` gain `PrepareChunk` / `FinalizeChunk`. `common_pb2.*` adds `PaymentEntry`. Other `*_pb2_grpc.py` files have header-only protobuf-version diffs. Client (`src/antd/_grpc.py`): * New `self._upload = upload_pb2_grpc.UploadServiceStub(...)` field on both clients. * Helpers `_prepare_upload_result_from_resp`, `_finalize_upload_result_from_resp`, `_prepare_chunk_result_from_resp` map proto messages to the existing REST-style dataclasses. Merkle fields (`depth`, `pool_commitments`, `merkle_payment_timestamp`) populated only when `payment_type == "merkle"`. Tests (`tests/test_grpc_client.py`): * New file: in-process mock servers using `grpc.server` (sync) and `grpc.aio.server` (async). `MockChunkServicer` covers `PrepareChunk` / `FinalizeChunk`; new `MockUploadServicer` covers `PrepareFileUpload` / `PrepareDataUpload` / `FinalizeUpload`. * 20 test cases parallel to the antd-rust / antd-go suites, covering visibility forwarded/omitted, wave-batch vs merkle, `data_map_address` presence on public, merkle `store_data_map` toggle, chunk already-stored short-circuit, chunk finalize body forwarding. Both sync and async paths. Gates on dev2: * `pytest tests/` — 81/81 passing (61 existing + 20 new). * No ruff/mypy config exists in the project (dev2 sweep is the gate); pytest is the only enforced check. Depends on the antd-side daemon PR landing first. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 task
This was referenced May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the three
NotImplementedErrorstubs onGrpcClient/AsyncGrpcClientforprepare_upload/prepare_data_upload/finalize_uploadwith real implementations, and adds four new methods mirroring the REST client surface. Sync + async parity.Depends on #140 (antd-side
UploadService+ chunks prepare/finalize).Methods
prepare_upload(path, visibility=None)prepare_upload_public(path)visibility="public"prepare_data_upload(data, visibility=None)finalize_upload(upload_id, tx_hashes)finalize_merkle_upload(upload_id, winner_pool_hash, store_data_map=False)prepare_chunk_upload(data)finalize_chunk_upload(upload_id, tx_hashes) -> str14 total method impls (7 each on sync and async clients).
Wallet stubs (
wallet_address/wallet_balance/wallet_approve) are out of scope here — they belong to the separateWalletService-over-gRPC work and will land in a follow-up PR.Proto regen
python scripts/generate_proto.pyregenerated all stubs undersrc/antd/_proto/antd/v1/:upload_pb2.py/upload_pb2.pyi/upload_pb2_grpc.pychunks_pb2.*gainPrepareChunk/FinalizeChunkcommon_pb2.*addsPaymentEntry*_pb2_grpc.pyfiles: header-only protobuf-version diffImplementation notes
self._upload = upload_pb2_grpc.UploadServiceStub(...)field on both clients._prepare_upload_result_from_resp,_finalize_upload_result_from_resp,_prepare_chunk_result_from_respmap proto messages to the existing REST-style dataclasses. Merkle fields (depth,pool_commitments,merkle_payment_timestamp) populated only whenpayment_type == "merkle".Tests
New
tests/test_grpc_client.py:grpc.server(sync) andgrpc.aio.server(async), one per test on random127.0.0.1:0port.MockChunkServicercoversPrepareChunk(new + already-stored) andFinalizeChunk(echoupload_id).MockUploadServicercoversPrepareFileUpload/PrepareDataUpload/FinalizeUploadwith visibility round-trip viaupload_idencoding and merkle vs wave-batch branches.Gates passed on dev2
pytest tests/— 81/81 passing (61 existing + 20 new)pyproject.toml; the dev2 sweep is the gate (per project convention).E402warnings in_grpc.py(imports after helpers) are the file's prior style; not introduced by this PR.