feat(antd-java): gRPC external-signer prepare/finalize parity with REST - #144
Closed
Nic-dorman wants to merge 1 commit into
Closed
Conversation
Adds 7 new methods on `GrpcAntdClient` mirroring the existing REST `AntdClient` external-signer surface: * `prepareUpload(path, visibility)` / `prepareUpload(path)` / `prepareUploadPublic(path)` * `prepareDataUpload(data, visibility)` / `prepareDataUpload(data)` * `finalizeUpload(uploadId, txHashes)` (wave-batch) * `finalizeMerkleUpload(uploadId, winnerPoolHash, storeDataMap)` plus arity-2 overload defaulting `storeDataMap` to false * `prepareChunkUpload(data)` * `finalizeChunkUpload(uploadId, txHashes) -> String` The async surface (`AsyncAntdClient`) is REST-only — there is no async gRPC counterpart in this SDK — so the async paths are unchanged. Async gRPC support is out of scope here. Wallet stubs aren't present on `GrpcAntdClient`; the wallet-over-gRPC surface is a separate ticket. Proto/build: * Gradle's protobuf plugin auto-generates `Upload.*`, `Common.PaymentEntry`, and the new `Chunks.PrepareChunk*` / `Chunks.FinalizeChunk*` messages from `../antd/proto/`. No regen recipe to invoke. * `GrpcAntdClient` gains an `UploadServiceGrpc.UploadServiceBlockingStub uploadStub` field, constructed alongside the others. * Helpers `prepareResponseToResult` / `finalizeResponseToResult` translate proto into model records, populating merkle-only fields (`depth`, `poolCommitments`, `merklePaymentTimestamp`) only when `payment_type == "merkle"`. Tests (`GrpcAntdClientTest`): * `MockChunkService` gains `prepareChunk` (new + already-stored short-circuit) and `finalizeChunk` (echoes `upload_id` into address). * New `MockUploadService` covers wave-batch / merkle / visibility round-trip via `upload_id` encoding / `store_data_map` true|false. * 12 new tests parallel to the antd-rust / antd-go / antd-py suites. Gates passed on dev2: * `./gradlew compileJava` clean * `./gradlew test --tests GrpcAntdClientTest` — 31/31 (the 19 existing plus 12 new) * `./gradlew build` — full project including examples passes Depends on the antd-side daemon PR landing first. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds 7 new methods on
GrpcAntdClientmirroring the existing RESTAntdClientexternal-signer surface.Depends on #140 (antd-side
UploadService+ chunks prepare/finalize).Methods
prepareUpload(path)/prepareUpload(path, visibility)prepareUploadPublic(path)visibility="public"prepareDataUpload(data)/prepareDataUpload(data, visibility)finalizeUpload(uploadId, txHashes)finalizeMerkleUpload(uploadId, winnerPoolHash)/finalizeMerkleUpload(uploadId, winnerPoolHash, storeDataMap)prepareChunkUpload(data)finalizeChunkUpload(uploadId, txHashes) -> StringThe async client (
AsyncAntdClient) is REST-only — there is no async-gRPC counterpart in this SDK — so the async paths are unchanged. Async gRPC support would be a separate scope.Wallet stubs aren't present on
GrpcAntdClient; wallet-over-gRPC is a separate ticket.Proto/build
Gradle's protobuf plugin auto-generates
Upload.*,Common.PaymentEntry, and the newChunks.PrepareChunk*/Chunks.FinalizeChunk*messages from../antd/proto/. No regen recipe to run — gradle picks up the newupload.protoautomatically.GrpcAntdClientgains anUploadServiceGrpc.UploadServiceBlockingStub uploadStubfield, constructed alongside the others.Helpers
prepareResponseToResult/finalizeResponseToResulttranslate proto into model records, populating merkle-only fields (depth,poolCommitments,merklePaymentTimestamp) only whenpayment_type == "merkle".Tests
GrpcAntdClientTest:MockChunkServicegainsprepareChunk(new + already-stored short-circuit) andfinalizeChunk(echoesupload_idinto address).MockUploadServicecovers wave-batch / merkle response shapes, visibility round-trip viaupload_idencoding, andstore_data_maptrue/false branches.Gates passed on dev2
./gradlew compileJavaclean./gradlew test --tests GrpcAntdClientTest— 31/31 passing./gradlew build— full project (lib + examples) passes