feat(antd-cpp): gRPC WalletService parity with REST - #167
Closed
Nic-dorman wants to merge 2 commits into
Closed
Conversation
Adds WalletService over gRPC mirroring the existing REST surface 1:1: * GetAddress(GetWalletAddressRequest) → GetWalletAddressResponse * GetBalance(GetWalletBalanceRequest) → GetWalletBalanceResponse * Approve(WalletApproveRequest) → WalletApproveResponse Pure-gRPC consumers (e.g. Indelible's wallet-less external-signer flow that still wants /diagnostics + balance) no longer need to keep a REST client alongside just for wallet ops, and the dual-transport SDKs can stop returning UnsupportedOperationException on their *GrpcClient. Implementation notes: * New proto/antd/v1/wallet.proto added to build.rs's compile list and the grpc/mod.rs serve registration. * WalletServiceImpl in grpc/service.rs reuses antd/src/rest/wallet.rs's handler bodies — Client::wallet() access is transport-agnostic; the approve path spawns a tokio task to match REST. * Missing wallet returns Status::failed_precondition (the gRPC analog of REST's 503 service-unavailable for this case) with the same "wallet not configured — set AUTONOMI_WALLET_KEY" message. Out of scope: * SDK fan-out — covered in 11 follow-up PRs (rust/go/py/java/kotlin/ csharp/ruby/dart/swift/cpp/elixir). * Wallet configuration over gRPC — V2-335 (post-v1.0). * External-signer prepare/finalize — shipped separately via the UploadService + ChunkService PrepareChunk/FinalizeChunk RPCs from the V2-284 daemon PR. Gates on dev2: * cargo check / clippy -- -D warnings — clean on antd + antd-rust. * cargo test — 37/37 passing. * cargo fmt --check — clean. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Adds 3 new methods on antd::GrpcClient mirroring REST antd::Client: * WalletAddress wallet_address() * WalletBalance wallet_balance() * bool wallet_approve() Implementation notes: * New antd::v1::WalletService::Stub on the existing pimpl, alongside the existing health/data/chunk/file stubs. * A missing daemon wallet emits gRPC FAILED_PRECONDITION; the existing check_status helper maps it to antd::PaymentError (established FailedPrecondition->Payment convention across all SDKs). Tests (tests/test_grpc_wallet.cpp, new): * Spins up a real grpc++ server on 127.0.0.1:0 with MockWalletService + UnconfiguredWalletService implementations, then dials with a real antd::GrpcClient. * 4 tests: address, balance, approve, plus the unconfigured-wallet PaymentError path. * Gated on -DANTD_BUILD_GRPC=ON, same as the V2-284 cpp PR's antd_grpc_external_signer_tests pattern. Gates on dev2: * cmake -B build -DANTD_BUILD_GRPC=ON -DProtobuf_PROTOC_EXECUTABLE=/usr/bin/protoc cmake --build build ctest --test-dir build * 4/4 tests passing (antd_tests, antd_async_tests, antd_grpc_tests isolated, antd_grpc_wallet_tests V2-286). Depends on the antd-side daemon PR landing first. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Nic-dorman
force-pushed
the
nic/v2-286-antd-grpc-walletservice
branch
from
May 28, 2026 15:51
b02ff94 to
1cfddfb
Compare
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds 3 new methods on
antd::GrpcClientmirroring RESTantd::Client:WalletAddress wallet_address()WalletBalance wallet_balance()bool wallet_approve()Depends on #154.
Implementation notes
antd::v1::WalletService::Stubon the existing pimpl, alongside the existing health/data/chunk/file stubs.FAILED_PRECONDITION; the existingcheck_statushelper maps it toantd::PaymentError.Tests
tests/test_grpc_wallet.cpp(new):127.0.0.1:0withMockWalletService+UnconfiguredWalletServiceimplementations.PaymentErrorpath.-DANTD_BUILD_GRPC=ON, same as the V2-284 cpp PR'santd_grpc_external_signer_testspattern.Gates passed on dev2
antd_tests,antd_async_tests,antd_grpc_testsisolated,antd_grpc_wallet_testsV2-286)