Skip to content

Improve favicons#7

Open
d4rklynk wants to merge 4 commits intoWonderfall:masterfrom
d4rklynk:pr-improve-favicons
Open

Improve favicons#7
d4rklynk wants to merge 4 commits intoWonderfall:masterfrom
d4rklynk:pr-improve-favicons

Conversation

@d4rklynk
Copy link
Copy Markdown

@d4rklynk d4rklynk commented Dec 16, 2023 •
edited
Loading

  • Add mask_icon color
  • Add manifest

@d4rklynk
Improve favicons
df6d059 
- Add mask_icon color
- Add manifest
- Make icon type, apple-touch-icon type, and svg (mask_icon) type explicit
@d4rklynk
Copy link
Copy Markdown
Author

d4rklynk commented Dec 16, 2023

I overwrote the head.html on my website, it seems to work properly: https://realfavicongenerator.net/favicon_checker?protocol=https&site=simpleprivacy.fr

@wrobelda
Copy link
Copy Markdown

wrobelda commented Apr 25, 2024

I wonder if you could also make it possible to disable each of these assets? Right now, if there's no favicons configured, the code returns default names, even if they point to non-existing assets.

@d4rklynk
Copy link
Copy Markdown
Author

d4rklynk commented Apr 25, 2024 •
edited
Loading

The right to do it would be to create a generic favicon for it I guess

@wrobelda
Copy link
Copy Markdown

wrobelda commented Apr 25, 2024

The right to do it would be to create a generic favicon for it I guess

I might be missing something, but the right way is simply to allow the website to not have a favicon at all, instead of forcing to use a generic one?

@d4rklynk
Copy link
Copy Markdown
Author

d4rklynk commented Apr 25, 2024

Well, I would prefer to let Wonderfall have his opinion on this matter.
Tbf, I'm not a dev, and I'm not even sure how I could apply that anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@d4rklynk @wrobelda