PHP 8 | ControlStructureSpacing: bug fix - $data should be an array#1935
Merged
GaryJones merged 1 commit intoJul 21, 2020
Merged
Conversation
The `$data` parameter of the `$phpcsFile->add[Fixable]Error|Warning()` methods is expected to be an array, not a string. Without this fix, PHP 8 will throw and (uncaught) `TypeError: vsprintf(): Argument #2 ($args) must be of type array, string given`.
dingo-d
approved these changes
Jul 21, 2020
GaryJones
approved these changes
Jul 21, 2020
|
I'm trying to set phpcs and keep getting this error. When will this be merged into master? It was fixed quite a while ago. |
Member
Author
|
@stingray21 When we're ready to release version 3.0.0. |
2 tasks
|
Howdy! Is there anything we can do to help get this shipped out? |
Member
Author
|
@kraftbj If you can get PHP Core to slow down with the deprecations, so I can focus back on CS work instead of spending all my time on PHP 8.1 fixes, that would be lovely! |
DumbergerL
pushed a commit
to 5pm-HDH/wp-plugin-churchtools-anmeldungen
that referenced
this pull request
Feb 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
$dataparameter of the$phpcsFile->add[Fixable]Error|Warning()methods is expected to be an array, not a string.Without this fix, PHP 8 will throw an (uncaught)
TypeError: vsprintf(): Argument #2 ($args) must be of type array, string given.