Fix Windows blueprint import cleanup#280
Open
bcotrim wants to merge 2 commits into
Open
Conversation
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes Windows failures when running
blueprints.pharagainst an existing Studio site using native PHP.There are two related issues:
scripts/import-content.php, but that script already starts PHP and does not close it. Adding another<?php/?>wrapper can make the generated import subprocess script invalid.Changes
run_content_import([...])call.FilesystemExceptionduring final temporary workspace cleanup so a cleanup failure does not fail successful blueprint execution.Testing Instructions
Tested on Windows using PHP 8.4 and a Studio-created SQLite site.
Create a site in Studio.
Quit Studio.
Ensure the SQLite integration is available at:
If Studio only has it under
mu-plugins, create a junction/symlink frompluginstomu-plugins.If the Studio site's
wp-config.phpdoes not defineDB_NAME, temporarily add:Download and extract a blueprint bundle that imports WXR content, for example:
As a control, run the latest GitHub
blueprints.pharagainst the site:Before this patch, the run failed with:
{"type":"error","message":"Failed to remove directory: C:/Users/.../AppData/Local/Temp/wp-blueprints-runtime-..."}Build the patched PHAR:
Run the same blueprint with the patched PHAR:
Confirm the output contains:
{"type":"completion","message":"Blueprint successfully executed."}Restore
wp-config.phpifDB_NAMEwas added only for this test.