Speed up native URL rewriting#283
Merged
Merged
Conversation
This was referenced May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
URLInTextProcessorthroughNativeURLInTextProcessorwhen the native extension is loaded, while preserving the public PHP API around parsing, validation, and replacement.wp_rewrite_urls()for final rewrite decisions keyed by mapping, token type, and raw URL.Why
Large imports can contain hundreds of thousands of repeated URL occurrences. The native scanner can find candidates quickly, but the old public path still paid repeated PHP WHATWG parsing and
replace_base_url()costs for the same raw URLs.The caches are capped at 4096 entries each to avoid unbounded memory growth.
Benchmarks
Fixture: 5,000 sampled
post_contentvalues from a large Studio/reprint dump, 16.9 MB decoded content, 350,000 URL occurrences, 2 unique raw URLs. Runtime: PHP.wasm 8.4.21 withwp_native_apisloaded.wp_rewrite_urls()wall time44c9750c...44c9750c...PHPURLInTextProcessorNativeURLInTextProcessorWrapperValidation
vendor/bin/phpcbf -d memory_limit=1G components/DataLiberation/URL/class-nativeurlintextprocessorwrapper.php components/DataLiberation/URL/class-urlintextprocessor.php components/DataLiberation/URL/functions.phpvendor/bin/phpcs -d memory_limit=1G components/DataLiberation/URL/class-nativeurlintextprocessorwrapper.php components/DataLiberation/URL/class-urlintextprocessor.php components/DataLiberation/URL/functions.phpvendor/bin/phpunit -c phpunit.xml components/DataLiberation/Tests/URLInTextProcessorTest.php components/DataLiberation/Tests/RewriteUrlsTest.phpphp extensions/native-apis/tests/verify-native-apis.php --allow-missingwp_native_apisloadedFull
composer testcurrently has one unrelated failure inWordPress\\Blueprints\\Tests\\Unit\\Steps\\DefineConstantsStepTest::testAddNewConstantsToInvalidWpConfigon PHP 8.4.5: the expected Blueprint error text is absent from the subprocess exception output.