feat(checks): detect production-time PHP error reporting changes#1317
Open
faisalahammad wants to merge 1 commit into
Open
feat(checks): detect production-time PHP error reporting changes#1317faisalahammad wants to merge 1 commit into
faisalahammad wants to merge 1 commit into
Conversation
- Add Php_Error_Reporting_Check to detect error_reporting(), ini_set('display_errors'), and redefine of debug constants (WP_DEBUG, etc.).
- Register Php_Error_Reporting_Check in Default_Check_Repository.
- Add unit tests and test plugins fixtures for verification.
Fixes WordPress#1315
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new static check
Php_Error_Reporting_Checkthat flags plugins which modify PHP error-reporting configurations or redefine core WordPress debug constants in production. This prevents sensitive information disclosure and ensures a standard debugging experience on WordPress sites.Fixes #1315
Changes
Php_Error_Reporting_CheckBefore:
No check existed to flag PHP error reporting changes.
After:
Why: Leverages an AST-based search (using
PhpParser\\ParserFactory) to precisely flag directerror_reporting()calls,ini_set()/ini_alter()calls witherror_reporting/display_errors, and the definition of core debug constants (WP_DEBUG, etc.). The check has a robust fallback to regex search if AST parsing fails.Default_Check_RepositoryBefore:
After:
Why: Registers the new static check class as a default check in the General category.
Testing
Test 1: Run the automated unit test suite
Result: Works as expected (2 tests, 6 assertions successfully pass).
Test 2: Perform static analysis and lint checks
composer run-script lintcomposer run-script phpstanResult: Works as expected (0 errors, completely clean).