feat(1314): add unclosed ob_start check#1318
Open
faisalahammad wants to merge 3 commits into
Open
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
2f01cac to
32eccbe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new performance check to detect
ob_start()calls that are not closed within the same scope. This prevents unpredictable behaviour caused by misaligned output buffers in shared environments.Fixes #1314
Changes
includes/Checker/Checks/Performance/Unclosed_Ob_Start_Check.phpBefore:
// File did not existAfter:
Why: A custom static analysis implementation utilizing
token_get_all()accurately tracks block scope (T_FUNCTION,{,}) to ensure everyob_start()is reliably paired with a closing function on the same scope level.includes/Checker/Default_Check_Repository.phpBefore:
After:
Why: Registers the newly created check to be automatically instantiated when scanning plugins.
Testing
Test 1: Unclosed ob_start Detection
ob_start();at the root without closing it, and inside a function but conditionally closed inside anifblock.wp plugin check <dummy-plugin>.ob_start()calls on the specific lines as performance warnings.Result: Works as expected