add Abstract_PHP_CodeSniffer_Check#53
Merged
mukeshpanchal27 merged 9 commits intoJan 12, 2023
Merged
Conversation
jjgrainger
added
[Type] Enhancement
mukeshpanchal27
left a comment
mukeshpanchal27
left a comment
Member
There was a problem hiding this comment.
Thanks @jjgrainger, Left some nit-pick.
Sincemissing on function documents- Use
n.e.x.tinstead of actual version1.0.0
felixarntz
reviewed
Jan 9, 2023
felixarntz
left a comment
felixarntz
left a comment
Member
There was a problem hiding this comment.
@jjgrainger Overall looks solid, a bit of nit-pick feedback.
felixarntz
approved these changes
Jan 12, 2023
felixarntz
left a comment
felixarntz
left a comment
Member
There was a problem hiding this comment.
@jjgrainger Thanks, this looks excellent now!
mukeshpanchal27
approved these changes
Jan 12, 2023
mukeshpanchal27
left a comment
mukeshpanchal27
left a comment
Member
There was a problem hiding this comment.
Thanks @jjgrainger, LGTM!
mukeshpanchal27
deleted the
feature/create-abstract-php-codesniffer-check
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the Abstract_PHP_CodeSniffer_Check class
Closes #8