Skip to content

53431: moves reset of current screen globals to base test case#1380

Closed
hellofromtonya wants to merge 20 commits into
WordPress:masterfrom
hellofromtonya:fix/53431-reset-current-screen-global
Closed

53431: moves reset of current screen globals to base test case#1380
hellofromtonya wants to merge 20 commits into
WordPress:masterfrom
hellofromtonya:fix/53431-reset-current-screen-global

Conversation

@hellofromtonya

Copy link
Copy Markdown
Contributor

Trac ticket: https://core.trac.wordpress.org/ticket/53431

Moves the resetting of current screen globals from individual tests to the base test case.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@johnbillion johnbillion left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good apart from using front in test_help_tabs(), not a big issue though.

Comment thread tests/phpunit/tests/admin/includesScreen.php Outdated
@hellofromtonya

Copy link
Copy Markdown
Contributor Author

Committed in changeset 51419

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants