Skip to content

Conversation

@sydneyjodon-wk
Copy link
Contributor

@sydneyjodon-wk sydneyjodon-wk commented Oct 25, 2024

Motivation

Make some last updates to prep the rename codemod for the sourcegraph batch

Changes

  • Update the codemod to:
    • no longer make changes to import namespaces
    • update data_grid_premium.dart entrypoint which is different on unify_ui
    • update / add fixme comments to make sure everything that needs to be manually QAed has a comment saying so
    • add LinkButton constants to list to be updated
  • Update tests

Release Notes

Review

See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.

Please review:

QA Checklist

  • Tests were updated and provide good coverage of the changeset and other affected code
  • Manual testing was performed if needed
    • Steps from PR author:
      • Run updated tests locally since they aren't run in CI
      • CI passes
      • Run the codemod on another repo (there are a few edge cases that the codemod won't cover that we'll just have to update on a case-by-case basis)
    • Anything falling under manual testing criteria outlined in CONTRIBUTING.md

Merge Checklist

While we perform many automated checks before auto-merging, some manual checks are needed:

  • A Frontend Frameworks Design member has reviewed these changes
  • There are no unaddressed comments - this check can be automated if reviewers use the "Request Changes" feature
  • For release PRs - Version metadata in Rosie comment is correct

@aviary2-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@sydneyjodon-wk sydneyjodon-wk marked this pull request as ready for review October 29, 2024 18:15
Copy link
Contributor

@greglittlefield-wf greglittlefield-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question and a #nit, otherwise LGTM, and works and has passing tests locally!

Copy link
Contributor

@greglittlefield-wf greglittlefield-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Changes look good
  • Tests pass locally
  • Output looks good when run against packages locally

+10

@greglittlefield-wf
Copy link
Contributor

@Workiva/release-management-p

Copy link

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rm-astro-wf rm-astro-wf merged commit 4a741ba into master Nov 1, 2024
@rm-astro-wf rm-astro-wf deleted the update-rename-codemod branch November 1, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants