Raise the Dart SDK minimum to at least 2.11.0 #124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
aaronlademann-wf
force-pushed
the
batch/client_platform/up_dart_sdk_minimum_to_2.11
branch
from
3d690d0 to
195e6bd
Compare
aaronlademann-wf
force-pushed
the
batch/client_platform/up_dart_sdk_minimum_to_2.11
branch
from
195e6bd to
df7ca3f
Compare
sydneyjodon-wk
approved these changes
Sep 21, 2021
Contributor
sydneyjodon-wk
left a comment
sydneyjodon-wk
left a comment
There was a problem hiding this comment.
+10
- CI on Dart 2.13.4 passes
@Workiva/release-management-p
rmconsole-wf
added
RM Ready
Merge Requirements Met
and removed
Merge Requirements Unmet
labels
rmconsole5-wk
deleted the
batch/client_platform/up_dart_sdk_minimum_to_2.11
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This updates the minimum Dart version that can be used to at least 2.11.0. Why 2.11.0 and not 2.13.4? Because setting it to 2.12.0 or higher opts the project into null safety (https://dart.dev/null-safety) which our code has not been migrated to yet.
What about null safety?
Once a project has been migrated to null safety it is ok to update the minimum to 2.12.0 or even 2.13.4 since everyone at Workiva should be using 2.13.4 now.
Review / Testing / QA / Merge
If CI passes please review and merge. Most Dart CI has already been updated to run under 2.13.4 already so updating the minimum here doesn't change any code, or CI circumstances.
If CI fails, it's likely because an image in the Dockerfile or skynet.yaml is still running an older version of Dart. It should be updated to one with Dart 2.13. A list of existing 2.13 images lives here https://wiki.atl.workiva.net/display/CP/Dart+2.13+Upgrade Feel free to fix CI and get this PR merged. However if you don't get to it, be aware that Client Platform will be going through the batch to help fix any failures.
Please reach out to #support-client-plat with any questions.
Created by Sourcegraph batch change
Workiva/up_dart_sdk_minimum_to_2.11.