Narrow dependency_validator range to avoid NNBD issue #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
| build_runner: ^2.1.2 | ||
| build_test: ^2.1.3 | ||
| build_web_compilers: ^3.0.0 | ||
| dependency_validator: ^3.2.2 |
Contributor
There was a problem hiding this comment.
Since this package is far enough upstream, we're able to upgrade to v3.2.2 which is the version with the fix for the NNBD issue. The rest of the dependency upgrades here are only for dev dependencies, which mean they don't impact downstream consumers.
evanweible-wf
requested review from
a team and
kealjones-wk
and removed request for
a team
kealjones-wk
approved these changes
Jul 15, 2022
Contributor
kealjones-wk
left a comment
kealjones-wk
left a comment
There was a problem hiding this comment.
+10 (Most CI is passing, the failing CI steps for "stable" dart is also failing on master in the same way so the failures are unrelated to this pr)
Contributor
|
@Workiva/release-management-p |
rmconsole-wf
added
Merge Requirements Met
RM Ready
and removed
Merge Requirements Unmet
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently discovered that if a package resolves to
dependency_validator >=3.0.0and
build_config <1.0.0, running thedependency_validatortool will failduring precompilation due to null safety.
We are merging a fix to
dependency_validator, but unfortunately it won'tprevent consumers from resolving to the v3.x versions that still have the
issue. This PR addresses the issue for consumers by narrowing the range to
no longer include
dependency_validator v3.Note: We originally widened this range as a part of the effort to upgrade
our ecosystem to
analyzer v1, but it is not strictly necessary. Consumersof
dependency_validator v2can still successfully resolve toanalyzer v1.For more info, reach out to
#support-frontend-architectureon Slack.Created by Sourcegraph batch change
Workiva/narrow_dependency_validator_range.