Project structure refactor and support for Java 17#22
Merged
karelmaxa merged 1 commit intoWrenSecurity:masterfrom Jul 13, 2022
Merged
Project structure refactor and support for Java 17#22karelmaxa merged 1 commit intoWrenSecurity:masterfrom
karelmaxa merged 1 commit intoWrenSecurity:masterfrom
Conversation
pavelhoral
force-pushed
the
java17-support
branch
2 times, most recently
from
3099867 to
ba0fd47
Compare
pavelhoral
changed the title
pavelhoral
force-pushed
the
java17-support
branch
from
ba0fd47 to
17fedf9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
XXXcomments throughout pom.xml files. They need to be addressed soon-ish.The only change I am not quite sure about is changing
connector-frameworkartifact toconnector-framework-core. This change makes sense, however it forces downstream projects to update artifactId together with groupId. This might be confusing and makes migration path a little bit more complex.