Restore Smarty to vendor version 2.6.28#20
Merged
Conversation
While debugging templating issue, found crash in debug template. After restoring pristine vendor source, crash and issue gone. Please leave it as is, warts and all.
mambax7
added a commit
that referenced
this pull request
Feb 28, 2016
Restore Smarty to vendor version 2.6.28
geekwright
added a commit
to geekwright/XoopsCore25
that referenced
this pull request
Feb 10, 2020
Cosmetic xmnews
This was referenced Feb 15, 2026
Closed
mambax7
added a commit
that referenced
this pull request
Mar 8, 2026
1. step.php: Null guards in edit, save, delete cases + null guard in profile_stepsave_toggle() + CSRF protection on toggle (switched to POST with security check)
2. field.php: Null guard in save-option-strings case
3. user.php: Null guard after $handler->getUser($uid)
4. prune.php: Extracted duplicate Request::getInt('notifyusers') to $notifyusers variable
5. edituser.php: Early validation of upload field before fetchMedia()
mambax7
added a commit
that referenced
this pull request
Mar 14, 2026
- Add @SuppressWarnings for intentionally unused $raw parameter in executeLegacyBlock() (Scrutinizer) - Remove redundant logger initialization in test — already handled by setUpBeforeClass() (CodeRabbit #18) - Skip protector lifecycle tests gracefully when trust-path files are not available in the test environment (CodeRabbit #19) - Add targeted warning for near-miss file-based block content that contains .php| but fails the strict regex (Copilot #20)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While debugging a templating issue, encountered a crash in debug template.
After restoring pristine vendor source, crash (and issue) were gone.
Please leave vendor code as is, warts and all. Thanks!