Enable custom servers with OAuth application id in url path.#17
Open
pejotes wants to merge 2 commits intoXeroAPI:masterfrom
Open
Enable custom servers with OAuth application id in url path.#17pejotes wants to merge 2 commits intoXeroAPI:masterfrom
pejotes wants to merge 2 commits intoXeroAPI:masterfrom
Conversation
As some OAuth providers allows to create custom OAuth server instances on the same hostname with application id in url path we should allow to discover them and all required endpoints.
Add path element to authority base url request to enable custom servers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please note some providers like for example Okta allows to create custom authorisation servers like described here
https://developer.okta.com/docs/concepts/auth-servers/
This allows to create custom servers for apps with separate urls based on schema.
"
OpenID: https://${yourOktaDomain}/oauth2//.well-known/openid-configuration
OAuth: https://${yourOktaDomain}/oauth2//.well-known/oauth-authorization-server
"
The change adds path component to discovery url for endpoints. Tested with generic hostname base url and this custom based.