Stephen/spider annotation dev#18
Merged
niansong1996 merged 2 commits intoDec 7, 2022
Merged
Conversation
…ade fix for spider_answer_eq to compare sorted answers if no ORDER because sql order is implementation dependent, finished 50 examples
niansong1996
reviewed
Dec 7, 2022
Contributor
niansong1996
left a comment
niansong1996
left a comment
There was a problem hiding this comment.
LGTM and thanks for uploading the annotations as well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Debugged spider execution python, added minor fixes for answer comparing sorting, finished 50 spider annotations