Implementing more CodeLMs#41
Conversation
niansong1996
left a comment
There was a problem hiding this comment.
Good work! Some questions:
- Do you have to update the huggingface transformers library version?
- On what device/GPU did you test the mathqa setting?
| # for llama-based model | ||
| return output.lstrip().split("\n\n")[0].strip() | ||
| else: | ||
| return output.lstrip().split(tokenizer_eos_token)[0].split("\n\n")[0].strip() |
There was a problem hiding this comment.
So LLAMA does not have an eos token?
There was a problem hiding this comment.
It defines the eos token as empty string: https://huggingface.co/decapoda-research/llama-7b-hf/blob/main/tokenizer_config.json
Yes. There has not been an official release that supports LLAMA, so I installed the transformer library from source.
The experimental setting was recorded in this google doc. I will use this doc for updates. |
|
To reiterate the action items discussed in the meeting:
Also I was wondering if this PR is ready to merge? You also mentioned that there are some edge cases that haven't been handled? |
I just updated the
Yes. LLAMA, Alpaca, and santacoder should work fine using the config file: |
|
@yilunzhao Can you resolve the conflicts and also merge from main to run the CI tests? |
|
Great, merging this PR now |
|
@yilunzhao Check my comments on #46 Since we can't reopen a merged PR, can you submit a new PR and point it to this PR instead? Let me know if you have any questions. Sorry about the confusion. |
|
Hi @niansong1996, I have submit a new PR #48, could you please have a look at it? |
Working on #30 for this PR