compatibility issues from Indexable_Link_Builder function build resetting global post

[Jon007]

version 15.8 Indexable_Link_Builder function build( $indexable, $content ) {
resets the global post data which causes compatibility issues for any customisations which modify new posts and may well be the underlying issue to #16672, #16600 and others

This was identified and reported to me by @fkoomek on https://gist.github.com/Jon007/ae3a112659d6670ebbd2f26d55143773
and I have retested and replicated: putting a simple return statement at the top of this Indexable_Link_Builder function build to bypass it. This solves the compatibility issues.

• I've read and understood the contribution guidelines.
• I've searched for any related issues and avoided creating a duplicate issue.

Please give us a description of what happened.

When code customises a new post, in this case of type WooCommerce Product, custom attributes are lost when Yoast Indexable_Link_Builder function build resets the post.

Please describe what you expected to happen and why.

In this case, attributes were being added by default to a WooCommerce Product using the gist:
https://gist.github.com/Jon007/ae3a112659d6670ebbd2f26d55143773
which type of code has worked for many years and continues to work today on WooCommerce 5 until Yoast is updated to 15.8

I've tried other hooks without success.

How can we reproduce this behavior?

1.https://gist.github.com/Jon007/ae3a112659d6670ebbd2f26d55143773

Technical info

• If relevant, which editor is affected (or editors):

• Classic Editor
• Gutenberg
• Classic Editor plugin
  Not relevant

• Which browser is affected (or browsers):

• Chrome
• Firefox
• Safari
• Other
  Not relevant - php issue not browser issue

Used versions

• WordPress version: 5.6.2
• Yoast SEO version: 15.9
• Gutenberg plugin version:
• Classic Editor plugin version:
• Relevant plugins in case of a bug:

• Tested with theme: Storefront

[stodorovic]

It should be fixed by #16689. You can try version 16.0 RC1.

[Jon007]

no, it doesn't quite work,

for me it works if I modify
ad12173
to:
if ( $indexable->object_type === 'post' && $post) {
but this simply causes the code to be skipped, which may be a good thing:

• why is this plugin trying to reset content and build links on a new empty post with no content?

At this point for a new post the global $post is null and the forced reloading of the post is merely returning an empty $content on which no meaningful build processing can be done.
Even if the post had default content in memory added by another plugin then the code would be deleting it by force resetting the content?

[Jon007]

I suspect the original change to build() on 9b4f7ca#diff-3b3c3fe90f75b2e93fe8ed4d29c14aebd7f0924f5b198c9cea29f9ccbce90b86
might not be needed, the most compatible solution would be to ignore when the post is not set

[Djennez]

So it looks like setup_postdata() is the main culprit, and not necessarily the wp_reset_postdata(). However, I don't know why, as your code seems to run after the link indexer. Nonetheless, I come to the same conclusion that this piece of code is not useful in this context, as it tries to build links from an empty post.

I'll see what's possible and discuss this internally.

[Djennez]

@Jon007 15.9.1 was just released and should fix this issue. Can you verify this for us?

[Jon007]

@Djennez confirmed and closed thanks