Skip to content

Let test suites define completion criterias - #15

Merged
solsson merged 6 commits into
masterfrom
assert-completions-and-ci-runs
Jun 5, 2020
Merged

Let test suites define completion criterias#15
solsson merged 6 commits into
masterfrom
assert-completions-and-ci-runs

Conversation

@solsson

@solsson solsson commented Jun 5, 2020

Copy link
Copy Markdown
Contributor

No description provided.

solsson added a commit to Yolean/ystack that referenced this pull request Jun 5, 2020
@solsson

solsson commented Jun 5, 2020

Copy link
Copy Markdown
Contributor Author

This PR basically adds the following new metrics and leaves the rest for workflows, like Yolean/ystack#30:

# HELP assert_files_seen Unique spec file paths that have been seen in onTestResult
# TYPE assert_files_seen gauge
assert_files_seen 2

# HELP assert_completions_passed Gets a value if a spec names assert-completion.spec.js has run
# TYPE assert_completions_passed gauge
assert_completions_passed 5

# HELP assert_completions_remaining The number of failures for assert-completion.spec.js (pending and todo are ignored)
# TYPE assert_completions_remaining gauge
assert_completions_remaining 0

The assumption is that workflows can use assert_completions_remaining existence AND ==0, probably matching label namespace or pod, as a criteria to terminate specs runners.

@solsson
solsson merged commit 825e497 into master Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant