Potential update to `v0.2.0`

[cr1901]

I have made a PR for a breaking change in svd2rust. You may wish to regenerated your device crate using this change, as well as test the upcoming v0.2.0 of msp430-rt: https://github.com/cr1901/msp430-quickstart/tree/rt-up

All crates can be downloaded as git dependencies for the time being, I would like someone besides me to test that things don't break.

[YuhanLiin]

I updated my device PAC crate with your updated svd2rust branch and bumped all my dependencies. I managed to compile blinky example after a some minor changes but ran into an interrupt-related link error. You can pull the "rt-up" branch and run xargo build --example blinky to test it yourself.

error: linking with `msp430-elf-gcc` failed: exit code: 1
  |
  = note: "msp430-elf-gcc" "-L" "/home/yuhan/.xargo/lib/rustlib/msp430-none-elf/lib" "/home/yuhan/projects/rust/embedded/msp430-quickstart/target/msp430-none-elf/debug/examples/blinky-e1b17ab32204fb1f.1qcio1yyo7m6wqey.rcgu.o" "/home/yuhan/projects/rust/embedded/msp430-quickstart/target/msp430-none-elf/debug/examples/blinky-e1b17ab32204fb1f.46bso8plc10d7riz.rcgu.o" "/home/yuhan/projects/rust/embedded/msp430-quickstart/target/msp430-none-elf/debug/examples/blinky-e1b17ab32204fb1f.48ngmkk02pjn1n89.rcgu.o" "/home/yuhan/projects/rust/embedded/msp430-quickstart/target/msp430-none-elf/debug/examples/blinky-e1b17ab32204fb1f.5s5yrpprc1rdlqs.rcgu.o" "-o" "/home/yuhan/projects/rust/embedded/msp430-quickstart/target/msp430-none-elf/debug/examples/blinky-e1b17ab32204fb1f" "-Wl,--gc-sections" "-nodefaultlibs" "-L" "/home/yuhan/projects/rust/embedded/msp430-quickstart/target/msp430-none-elf/debug/deps" "-L" "/home/yuhan/projects/rust/embedded/msp430-quickstart/target/debug/deps" "-L" "/home/yuhan/projects/rust/embedded/msp430-quickstart/target/msp430-none-elf/debug/build/msp430-rt-ba067b7eeca5a4b2/out" "-L" "/home/yuhan/projects/rust/embedded/msp430-quickstart/target/msp430-none-elf/debug/build/msp430fr2355-ed5b176125ea0dd1/out" "-L" "/home/yuhan/.xargo/lib/rustlib/msp430-none-elf/lib" "-Wl,--start-group" "-Wl,-Bstatic" "/home/yuhan/projects/rust/embedded/msp430-quickstart/target/msp430-none-elf/debug/deps/libpanic_msp430-1f66dcabe49daa70.rlib" "/home/yuhan/projects/rust/embedded/msp430-quickstart/target/msp430-none-elf/debug/deps/libmsp430fr2355-98bb69cb488168cc.rlib" "/home/yuhan/projects/rust/embedded/msp430-quickstart/target/msp430-none-elf/debug/deps/libvcell-968d64038832c098.rlib" "/home/yuhan/projects/rust/embedded/msp430-quickstart/target/msp430-none-elf/debug/deps/libmsp430_rt-023653564cc5c6e5.rlib" "/home/yuhan/projects/rust/embedded/msp430-quickstart/target/msp430-none-elf/debug/deps/libr0-6bde90f43bcb4d13.rlib" "/home/yuhan/projects/rust/embedded/msp430-quickstart/target/msp430-none-elf/debug/deps/libmsp430-8a4ed3bf208a712b.rlib" "/home/yuhan/projects/rust/embedded/msp430-quickstart/target/msp430-none-elf/debug/deps/libbare_metal-ffcb0059d674f540.rlib" "/home/yuhan/.xargo/lib/rustlib/msp430-none-elf/lib/libcore-faea1fcb3d6f4bd7.rlib" "-Wl,--end-group" "/home/yuhan/.xargo/lib/rustlib/msp430-none-elf/lib/libcompiler_builtins-0f5fb972e828f512.rlib" "-nostartfiles" "-Tlink.x" "-lgcc" "-lmul_none" "-mcpu=msp430" "-Wl,-Bdynamic"
  = note: /home/yuhan/projects/rust/embedded/msp430-quickstart/target/msp430-none-elf/debug/deps/libmsp430_rt-023653564cc5c6e5.rlib(msp430_rt-023653564cc5c6e5.msp430_rt.2843knmx-cgu.0.rcgu.o):(.vector_table.interrupts+0x0): multiple definition of `__INTERRUPTS'
          /home/yuhan/projects/rust/embedded/msp430-quickstart/target/msp430-none-elf/debug/deps/libmsp430fr2355-98bb69cb488168cc.rlib(msp430fr2355-98bb69cb488168cc.msp430fr2355.a4t4a0vp-cgu.0.rcgu.o):(.vector_table.interrupts+0x0): first defined here
          /home/yuhan/msp430-gcc-8.2.0.52_linux64/bin/../lib/gcc/msp430-elf/8.2.0/../../../../msp430-elf/bin/ld: Warning: size of symbol `__INTERRUPTS' changed from 90 in /home/yuhan/projects/rust/embedded/msp430-quickstart/target/msp430-none-elf/debug/deps/libmsp430fr2355-98bb69cb488168cc.rlib(msp430fr2355-98bb69cb488168cc.msp430fr2355.a4t4a0vp-cgu.0.rcgu.o) to 30 in /home/yuhan/projects/rust/embedded/msp430-quickstart/target/msp430-none-elf/debug/deps/libmsp430_rt-023653564cc5c6e5.rlib(msp430_rt-023653564cc5c6e5.msp430_rt.2843knmx-cgu.0.rcgu.o)
          /home/yuhan/msp430-gcc-8.2.0.52_linux64/bin/../lib/gcc/msp430-elf/8.2.0/../../../../msp430-elf/bin/ld: error: /home/yuhan/projects/rust/embedded/msp430-quickstart/target/msp430-none-elf/debug/deps/libmsp430_rt-023653564cc5c6e5.rlib(msp430-rt.o) uses the upper region for data, but /home/yuhan/projects/rust/embedded/msp430-quickstart/target/msp430-none-elf/debug/examples/blinky-e1b17ab32204fb1f assumes data is in lower memory.
          /home/yuhan/msp430-gcc-8.2.0.52_linux64/bin/../lib/gcc/msp430-elf/8.2.0/../../../../msp430-elf/bin/ld: failed to merge target specific data of file /home/yuhan/projects/rust/embedded/msp430-quickstart/target/msp430-none-elf/debug/deps/libmsp430_rt-023653564cc5c6e5.rlib(msp430-rt.o)
          /home/yuhan/msp430-gcc-8.2.0.52_linux64/bin/../lib/gcc/msp430-elf/8.2.0/../../../../msp430-elf/bin/ld: address 0x1001e of /home/yuhan/projects/rust/embedded/msp430-quickstart/target/msp430-none-elf/debug/examples/blinky-e1b17ab32204fb1f section `.vector_table' is not within region `VECTORS'
          /home/yuhan/msp430-gcc-8.2.0.52_linux64/bin/../lib/gcc/msp430-elf/8.2.0/../../../../msp430-elf/bin/ld: address 0x1001e of /home/yuhan/projects/rust/embedded/msp430-quickstart/target/msp430-none-elf/debug/examples/blinky-e1b17ab32204fb1f section `.vector_table' is not within region `VECTORS'
          /home/yuhan/msp430-gcc-8.2.0.52_linux64/bin/../lib/gcc/msp430-elf/8.2.0/../../../../msp430-elf/bin/ld: 
          ERROR(msp430-rt): .vector_table is shorter than expected.
          Possible solutions, from most likely to less likely:
          - Link to a svd2rust generated pac crate, if you are not
          - Fix _sinterrupts in memory.x; it doesn't match the number of interrupts provided by the
            pac crate
          - Disable the 'device' feature of msp430-rt to build a generic application; a dependency
          may be enabling it
          
          /home/yuhan/projects/rust/embedded/msp430-quickstart/target/msp430-none-elf/debug/deps/libmsp430fr2355-98bb69cb488168cc.rlib(msp430fr2355-98bb69cb488168cc.msp430fr2355.a4t4a0vp-cgu.0.rcgu.o):(.vector_table.interrupts+0x2a): undefined reference to `PORT4'
          /home/yuhan/projects/rust/embedded/msp430-quickstart/target/msp430-none-elf/debug/deps/libmsp430fr2355-98bb69cb488168cc.rlib(msp430fr2355-98bb69cb488168cc.msp430fr2355.a4t4a0vp-cgu.0.rcgu.o):(.vector_table.interrupts+0x2c): undefined reference to `PORT3'
          /home/yuhan/projects/rust/embedded/msp430-quickstart/target/msp430-none-elf/debug/deps/libmsp430fr2355-98bb69cb488168cc.rlib(msp430fr2355-98bb69cb488168cc.msp430fr2355.a4t4a0vp-cgu.0.rcgu.o):(.vector_table.interrupts+0x2e): undefined reference to `PORT2'
          /home/yuhan/projects/rust/embedded/msp430-quickstart/target/msp430-none-elf/debug/deps/libmsp430fr2355-98bb69cb488168cc.rlib(msp430fr2355-98bb69cb488168cc.msp430fr2355.a4t4a0vp-cgu.0.rcgu.o):(.vector_table.interrupts+0x30): undefined reference to `PORT1'
          /home/yuhan/projects/rust/embedded/msp430-quickstart/target/msp430-none-elf/debug/deps/libmsp430fr2355-98bb69cb488168cc.rlib(msp430fr2355-98bb69cb488168cc.msp430fr2355.a4t4a0vp-cgu.0.rcgu.o):(.vector_table.interrupts+0x32): undefined reference to `SAC1_SAC3'
          /home/yuhan/projects/rust/embedded/msp430-quickstart/target/msp430-none-elf/debug/deps/libmsp430fr2355-98bb69cb488168cc.rlib(msp430fr2355-98bb69cb488168cc.msp430fr2355.a4t4a0vp-cgu.0.rcgu.o):(.vector_table.interrupts+0x34): undefined reference to `SAC0_SAC2'
          /home/yuhan/projects/rust/embedded/msp430-quickstart/target/msp430-none-elf/debug/deps/libmsp430fr2355-98bb69cb488168cc.rlib(msp430fr2355-98bb69cb488168cc.msp430fr2355.a4t4a0vp-cgu.0.rcgu.o):(.vector_table.interrupts+0x36): undefined reference to `ECOMP0_ECOMP1'
          /home/yuhan/projects/rust/embedded/msp430-quickstart/target/msp430-none-elf/debug/deps/libmsp430fr2355-98bb69cb488168cc.rlib(msp430fr2355-98bb69cb488168cc.msp430fr2355.a4t4a0vp-cgu.0.rcgu.o):(.vector_table.interrupts+0x38): undefined reference to `ADC'
          /home/yuhan/projects/rust/embedded/msp430-quickstart/target/msp430-none-elf/debug/deps/libmsp430fr2355-98bb69cb488168cc.rlib(msp430fr2355-98bb69cb488168cc.msp430fr2355.a4t4a0vp-cgu.0.rcgu.o):(.vector_table.interrupts+0x3a): undefined reference to `EUSCI_B1'
          /home/yuhan/projects/rust/embedded/msp430-quickstart/target/msp430-none-elf/debug/deps/libmsp430fr2355-98bb69cb488168cc.rlib(msp430fr2355-98bb69cb488168cc.msp430fr2355.a4t4a0vp-cgu.0.rcgu.o):(.vector_table.interrupts+0x3c): undefined reference to `EUSCI_B0'
          /home/yuhan/projects/rust/embedded/msp430-quickstart/target/msp430-none-elf/debug/deps/libmsp430fr2355-98bb69cb488168cc.rlib(msp430fr2355-98bb69cb488168cc.msp430fr2355.a4t4a0vp-cgu.0.rcgu.o):(.vector_table.interrupts+0x3e): undefined reference to `EUSCI_A1'
          /home/yuhan/projects/rust/embedded/msp430-quickstart/target/msp430-none-elf/debug/deps/libmsp430fr2355-98bb69cb488168cc.rlib(msp430fr2355-98bb69cb488168cc.msp430fr2355.a4t4a0vp-cgu.0.rcgu.o):(.vector_table.interrupts+0x40): undefined reference to `EUSCI_A0'
          /home/yuhan/projects/rust/embedded/msp430-quickstart/target/msp430-none-elf/debug/deps/libmsp430fr2355-98bb69cb488168cc.rlib(msp430fr2355-98bb69cb488168cc.msp430fr2355.a4t4a0vp-cgu.0.rcgu.o):(.vector_table.interrupts+0x42): undefined reference to `WDT'
          /home/yuhan/projects/rust/embedded/msp430-quickstart/target/msp430-none-elf/debug/deps/libmsp430fr2355-98bb69cb488168cc.rlib(msp430fr2355-98bb69cb488168cc.msp430fr2355.a4t4a0vp-cgu.0.rcgu.o):(.vector_table.interrupts+0x44): undefined reference to `RTC'
          /home/yuhan/projects/rust/embedded/msp430-quickstart/target/msp430-none-elf/debug/deps/libmsp430fr2355-98bb69cb488168cc.rlib(msp430fr2355-98bb69cb488168cc.msp430fr2355.a4t4a0vp-cgu.0.rcgu.o):(.vector_table.interrupts+0x46): undefined reference to `TIMER3_B1'
          /home/yuhan/projects/rust/embedded/msp430-quickstart/target/msp430-none-elf/debug/deps/libmsp430fr2355-98bb69cb488168cc.rlib(msp430fr2355-98bb69cb488168cc.msp430fr2355.a4t4a0vp-cgu.0.rcgu.o):(.vector_table.interrupts+0x48): undefined reference to `TIMER3_B0'
          /home/yuhan/projects/rust/embedded/msp430-quickstart/target/msp430-none-elf/debug/deps/libmsp430fr2355-98bb69cb488168cc.rlib(msp430fr2355-98bb69cb488168cc.msp430fr2355.a4t4a0vp-cgu.0.rcgu.o):(.vector_table.interrupts+0x4a): undefined reference to `TIMER2_B1'
          /home/yuhan/projects/rust/embedded/msp430-quickstart/target/msp430-none-elf/debug/deps/libmsp430fr2355-98bb69cb488168cc.rlib(msp430fr2355-98bb69cb488168cc.msp430fr2355.a4t4a0vp-cgu.0.rcgu.o):(.vector_table.interrupts+0x4c): undefined reference to `TIMER2_B0'
          /home/yuhan/projects/rust/embedded/msp430-quickstart/target/msp430-none-elf/debug/deps/libmsp430fr2355-98bb69cb488168cc.rlib(msp430fr2355-98bb69cb488168cc.msp430fr2355.a4t4a0vp-cgu.0.rcgu.o):(.vector_table.interrupts+0x4e): undefined reference to `TIMER1_B1'
          /home/yuhan/projects/rust/embedded/msp430-quickstart/target/msp430-none-elf/debug/deps/libmsp430fr2355-98bb69cb488168cc.rlib(msp430fr2355-98bb69cb488168cc.msp430fr2355.a4t4a0vp-cgu.0.rcgu.o):(.vector_table.interrupts+0x50): undefined reference to `TIMER1_B0'
          /home/yuhan/projects/rust/embedded/msp430-quickstart/target/msp430-none-elf/debug/deps/libmsp430fr2355-98bb69cb488168cc.rlib(msp430fr2355-98bb69cb488168cc.msp430fr2355.a4t4a0vp-cgu.0.rcgu.o):(.vector_table.interrupts+0x52): undefined reference to `TIMER0_B1'
          /home/yuhan/projects/rust/embedded/msp430-quickstart/target/msp430-none-elf/debug/deps/libmsp430fr2355-98bb69cb488168cc.rlib(msp430fr2355-98bb69cb488168cc.msp430fr2355.a4t4a0vp-cgu.0.rcgu.o):(.vector_table.interrupts+0x54): undefined reference to `TIMER0_B0'
          /home/yuhan/projects/rust/embedded/msp430-quickstart/target/msp430-none-elf/debug/deps/libmsp430fr2355-98bb69cb488168cc.rlib(msp430fr2355-98bb69cb488168cc.msp430fr2355.a4t4a0vp-cgu.0.rcgu.o):(.vector_table.interrupts+0x56): undefined reference to `UNMI'
          /home/yuhan/projects/rust/embedded/msp430-quickstart/target/msp430-none-elf/debug/deps/libmsp430fr2355-98bb69cb488168cc.rlib(msp430fr2355-98bb69cb488168cc.msp430fr2355.a4t4a0vp-cgu.0.rcgu.o):(.vector_table.interrupts+0x58): undefined reference to `SYSNMI'
          collect2: error: ld returned 1 exit status

Do you know how to fix this?

[cr1901]

@YuhanLiin Try changing the linked line from rt = ["msp430-rt"] to rt = ["msp430-rt/device"]. Looks like you didn't enable the device feature of msp430-rt.

[YuhanLiin]

Updated and still get the same error

[YuhanLiin]

I also noticed that the __INTERRUPTS array for my chip starts with 21 reserved entries before any actual interrupts, which is reflective of the chip's ISR address space. Maybe that's causing the problem?

[cr1901]

I also noticed that the __INTERRUPTS array for my chip starts with 21 reserved entries before any actual interrupts, which is reflective of the chip's ISR address space. Maybe that's causing the problem?

Yes, possibly. I was hoping to avoid having to look at your part's datasheet but looks like I won't get that option. Something's wrong with the vector table... will take a look tomorrow.

[cr1901]

@YuhanLiin On my machine, compiling blinky works fine and completes without error. Can I see your lockfile?

Incidentally, according to the datasheet, the interrupt numbers generated by msp430_svd are incorrect. I need to figure out what's wrong there...

[YuhanLiin]

TI's device files used in msp430_svd for my chip have some issues, such as providing peripherals and registers that don't exist. Additionally, I did a cargo update followed by clean build and got a shorter link error this time.

"msp430-elf-gcc" "-L" "/home/yuhan/.xargo/lib/rustlib/msp430-none-elf/lib" "/home/yuhan/projects/rust/embedded/msp430-quickstart/target/msp430-none-elf/debug/examples/blinky-95aab4fa7f893bab.3k4l8ulmgcepe16w.rcgu.o" "/home/yuhan/projects/rust/embedded/msp430-quickstart/target/msp430-none-elf/debug/examples/blinky-95aab4fa7f893bab.4t33jv05nxr11thw.rcgu.o" "/home/yuhan/projects/rust/embedded/msp430-quickstart/target/msp430-none-elf/debug/examples/blinky-95aab4fa7f893bab.58pq37wxu66ftym9.rcgu.o" "/home/yuhan/projects/rust/embedded/msp430-quickstart/target/msp430-none-elf/debug/examples/blinky-95aab4fa7f893bab.xluaib33b93txiy.rcgu.o" "-o" "/home/yuhan/projects/rust/embedded/msp430-quickstart/target/msp430-none-elf/debug/examples/blinky-95aab4fa7f893bab" "-Wl,--gc-sections" "-nodefaultlibs" "-L" "/home/yuhan/projects/rust/embedded/msp430-quickstart/target/msp430-none-elf/debug/deps" "-L" "/home/yuhan/projects/rust/embedded/msp430-quickstart/target/debug/deps" "-L" "/home/yuhan/projects/rust/embedded/msp430-quickstart/target/msp430-none-elf/debug/build/msp430-rt-cd238077f9f981dc/out" "-L" "/home/yuhan/projects/rust/embedded/msp430-quickstart/target/msp430-none-elf/debug/build/msp430fr2355-ed5b176125ea0dd1/out" "-L" "/home/yuhan/.xargo/lib/rustlib/msp430-none-elf/lib" "-Wl,--start-group" "-Wl,-Bstatic" "/home/yuhan/projects/rust/embedded/msp430-quickstart/target/msp430-none-elf/debug/deps/libpanic_msp430-6b564e4c31d2902d.rlib" "/home/yuhan/projects/rust/embedded/msp430-quickstart/target/msp430-none-elf/debug/deps/libmsp430fr2355-eb90a2897e7303cd.rlib" "/home/yuhan/projects/rust/embedded/msp430-quickstart/target/msp430-none-elf/debug/deps/libvcell-968d64038832c098.rlib" "/home/yuhan/projects/rust/embedded/msp430-quickstart/target/msp430-none-elf/debug/deps/libmsp430_rt-3cd7335e0f235fa9.rlib" "/home/yuhan/projects/rust/embedded/msp430-quickstart/target/msp430-none-elf/debug/deps/libr0-6bde90f43bcb4d13.rlib" "/home/yuhan/projects/rust/embedded/msp430-quickstart/target/msp430-none-elf/debug/deps/libmsp430-f69a3835132a8b2c.rlib" "/home/yuhan/projects/rust/embedded/msp430-quickstart/target/msp430-none-elf/debug/deps/libbare_metal-ffcb0059d674f540.rlib" "/home/yuhan/projects/rust/embedded/msp430-quickstart/target/msp430-none-elf/debug/deps/libmsp430-d43475818367e53d.rlib" "/home/yuhan/projects/rust/embedded/msp430-quickstart/target/msp430-none-elf/debug/deps/libbare_metal-a7824c714dd2d651.rlib" "/home/yuhan/.xargo/lib/rustlib/msp430-none-elf/lib/libcore-faea1fcb3d6f4bd7.rlib" "-Wl,--end-group" "/home/yuhan/.xargo/lib/rustlib/msp430-none-elf/lib/libcompiler_builtins-0f5fb972e828f512.rlib" "-nostartfiles" "-Tlink.x" "-lgcc" "-lmul_none" "-mcpu=msp430" "-Wl,-Bdynamic"
  = note: /home/yuhan/msp430-gcc-8.2.0.52_linux64/bin/../lib/gcc/msp430-elf/8.2.0/../../../../msp430-elf/bin/ld: error: /home/yuhan/projects/rust/embedded/msp430-quickstart/target/msp430-none-elf/debug/deps/libmsp430_rt-3cd7335e0f235fa9.rlib(msp430-rt.o) uses the upper region for data, but /home/yuhan/projects/rust/embedded/msp430-quickstart/target/msp430-none-elf/debug/examples/blinky-95aab4fa7f893bab assumes data is in lower memory.
          /home/yuhan/msp430-gcc-8.2.0.52_linux64/bin/../lib/gcc/msp430-elf/8.2.0/../../../../msp430-elf/bin/ld: failed to merge target specific data of file /home/yuhan/projects/rust/embedded/msp430-quickstart/target/msp430-none-elf/debug/deps/libmsp430_rt-3cd7335e0f235fa9.rlib(msp430-rt.o)
          collect2: error: ld returned 1 exit status

I've also pushed the lockfile.

[cr1901]

TI's device files used in msp430_svd for my chip have some issues, such as providing peripherals and registers that don't exist.

In rust-embedded-land, it is not unheard of to have to manually modify SVD files from vendors (or in this case, the output from msp430_svd), I'm afraid. Though NXP is still far worse behaved than TI in my experience. I'll take a look w/ your lockfile...

[YuhanLiin]

I've already modded the SVD file for my chip, mainly removing non-existent regs and peripherals. The SVD file does have a "peripheral" at the end called _INTERRUPTS that contains entries for each ISR, and they seem to match what's in the datasheet.

[cr1901]

The SVD file does have a "peripheral" at the end called _INTERRUPTS that contains entries for each ISR, and they seem to match what's in the datasheet.

The priority numbers in the datasheet do not match those in the SVD file. E.g. PORT4 has priority 39, in the datasheet, but in the SVD it's interrupt 21.

PORT4's vector is at 0xFFCE. 0xFFCE - (39 * 2 bytes per interrupt) = 0xFF80, which would be the theoretical start of the vector table in this device. This matches the baseAddress for the _INTERRUPTS "peripheral" in the SVD file.

But the datasheet says that 0xFF80-0xFF8A and 0xFFA0 is used for BSL configuration. Hmmm, I wonder what TI's official linker scripts do here...

[YuhanLiin]

0xFFCE - (21 * 2) = 0xFFA4, which is the starting vector address I put in my memory.x file. This worked fine before, but is not correct according to the datasheet. Also I'm not sure what svd2rust does with the _INTERRUPT field.
I checked TI's linker script and its vectors start at 0xFFA2. There're 46 vectors plus the reset handler, compared to the 45 vectors generated by svd2rust. I'll upload the script as well.

[cr1901]

@YuhanLiin

Additionally, I did a cargo update followed by clean build and got a shorter link error this time.

I am still not able to duplicate your error, even with your lockfile and following your directions:

William@William-THINK MINGW64 ~/src/msp430fr2355-quickstart
$ cargo update
    Updating git repository `https://github.com/rust-embedded/msp430`
    Updating git repository `https://github.com/rust-embedded/msp430-rt`
    Updating crates.io index
    Updating git repository `https://github.com/YuhanLiin/msp430fr2355`
    Updating msp430fr2355 v0.3.0 (https://github.com/YuhanLiin/msp430fr2355?branch=rt-up#3ed0393d) -> #90506e8c

William@William-THINK MINGW64 ~/src/msp430fr2355-quickstart
$ git diff
warning: LF will be replaced by CRLF in Cargo.lock.
The file will have its original line endings in your working directory
diff --git a/Cargo.lock b/Cargo.lock
index ff4ddf2..489996c 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -63,7 +63,7 @@ dependencies = [
 [[package]]
 name = "msp430fr2355"
 version = "0.3.0"
-source = "git+https://github.com/YuhanLiin/msp430fr2355?branch=rt-up#3ed0393d46a40bbbbf7d060926d34690785c3a06"
+source = "git+https://github.com/YuhanLiin/msp430fr2355?branch=rt-up#90506e8c6f76c1725c2fc502731bc60c2e8b634f"
 dependencies = [
  "bare-metal 0.2.5 (registry+https://github.com/rust-lang/crates.io-index)",
  "msp430 0.1.0 (registry+https://github.com/rust-lang/crates.io-index)",

William@William-THINK MINGW64 ~/src/msp430fr2355-quickstart
$ xargo build --example blinky
   Compiling msp430fr2355 v0.3.0 (https://github.com/YuhanLiin/msp430fr2355?branch=rt-up#90506e8c)
   Compiling msp430-rt v0.2.0 (https://github.com/rust-embedded/msp430-rt?branch=rt-up#4b87ed0d)
   Compiling msp430fr2355-quickstart v0.1.0 (C:\msys64\home\William\src\msp430fr2355-quickstart)
warning: constant item is never used: `MAX_DCO_MUL_EXP`
  --> src\clocks.rs:10:1
   |
10 | const MAX_DCO_MUL_EXP: u8 = 10;
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: `#[warn(dead_code)]` on by default

warning: unused import: `interrupt`
 --> examples\blinky.rs:8:19
  |
8 | use msp430::{asm, interrupt};
  |                   ^^^^^^^^^
  |
  = note: `#[warn(unused_imports)]` on by default

    Finished dev [optimized + debuginfo] target(s) in 31.89s

William@William-THINK MINGW64 ~/src/msp430fr2355-quickstart
$ git rev-parse HEAD
ab97732d8c392a6d4993f06efb9b723d2e060d49

William@William-THINK MINGW64 ~/src/msp430fr2355-quickstart
$ msp430-elf-gcc --version
msp430-elf-gcc.exe (SOMNIUM Technologies Limited - msp430-gcc 5.3.0.219) 5.3.0
Copyright (C) 2015 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.


William@William-THINK MINGW64 ~/src/msp430fr2355-quickstart
$ rustc -V
rustc 1.39.0-nightly (b9de4ef89 2019-09-03)

William@William-THINK MINGW64 ~/src/msp430fr2355-quickstart
$ xargo -V
xargo 0.3.16
cargo 1.39.0-nightly (22f7dd049 2019-08-27)

William@William-THINK MINGW64 ~/src/msp430fr2355-quickstart
$ uname -a
MINGW64_NT-6.1-7601 William-THINK 3.0.7-338.x86_64 2019-05-24 10:50 UTC x86_64 Msys

Could you please give me versions of all your tools and OS?

[YuhanLiin]

yuhan@yuhan-X541UV ~/projects/rust/embedded/msp430fr2355 (rt-up) $ rustc -V
rustc 1.37.0-nightly (9a90d03ad 2019-06-29)
yuhan@yuhan-X541UV ~/projects/rust/embedded/msp430fr2355 (rt-up) $ xargo -V
xargo 0.3.15
cargo 1.37.0-nightly (4c1fa54d1 2019-06-24)
yuhan@yuhan-X541UV ~/projects/rust/embedded/msp430fr2355 (rt-up) $ uname -a
Linux yuhan-X541UV 4.15.0-72-generic #81-Ubuntu SMP Tue Nov 26 12:20:02 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
yuhan@yuhan-X541UV ~/projects/rust/embedded/msp430fr2355 (rt-up) $ msp430-elf-gcc -v
Using built-in specs.
COLLECT_GCC=msp430-elf-gcc
COLLECT_LTO_WRAPPER=/home/yuhan/msp430-gcc-8.2.0.52_linux64/bin/../libexec/gcc/msp430-elf/8.2.0/lto-wrapper
Target: msp430-elf
Configured with: ../../gcc/configure --target=msp430-elf --enable-languages=c,c++ --disable-nls --enable-initfini-array --build=x86_64-pc-linux-gnu --host=x86_64-pc-linux-gnu --enable-target-optspace --enable-newlib-nano-formatted-io --with-pkgversion='Mitto Systems Limited - msp430-gcc 8.2.0.52'
Thread model: single
gcc version 8.2.0 (Mitto Systems Limited - msp430-gcc 8.2.0.52) 
yuhan@yuhan-X541UV ~/projects/rust/embedded/msp430fr2355 (rt-up) $ msp430-elf-ld -v
GNU ld (Mitto Systems Limited - msp430-gcc 8.2.0.52) 2.26.20160125

Outdated xargo and rustc on my side it seems. Will try updating those. Also can you check your version of MSP430-GCC/LD?

[cr1901]

I downloaded a copy of gcc 8.3.1 from TI's website; I couldn't duplicate your error after a clean build (note that I swapped to a Linux machine for this):

william@xubuntu-dtrain:~/Projects/msp430fr2355-quickstart$ xargo clean
william@xubuntu-dtrain:~/Projects/msp430fr2355-quickstart$ xargo build --example blinky
   Compiling semver-parser v0.7.0
   Compiling proc-macro2 v0.4.30
   Compiling autocfg v0.1.7
   Compiling rand_core v0.4.2
   Compiling unicode-xid v0.1.0
   Compiling libc v0.2.66
   Compiling syn v0.15.44
   Compiling msp430-rt v0.2.0 (https://github.com/rust-embedded/msp430-rt?branch=rt-up#4b87ed0d)
   Compiling msp430fr2355 v0.3.0 (https://github.com/YuhanLiin/msp430fr2355?branch=rt-up#90506e8c)
   Compiling r0 v0.2.2
   Compiling bare-metal v0.1.3
   Compiling vcell v0.1.2
   Compiling rand_core v0.3.1
   Compiling rand_jitter v0.1.4
   Compiling semver v0.9.0
   Compiling rand_chacha v0.1.1
   Compiling rand_pcg v0.1.2
   Compiling rand v0.6.5
   Compiling rand_xorshift v0.1.1
   Compiling rand_hc v0.1.0
   Compiling rand_isaac v0.1.1
   Compiling msp430 v0.1.0
   Compiling panic-msp430 v0.1.0
   Compiling rustc_version v0.2.3
   Compiling bare-metal v0.2.5
   Compiling msp430 v0.2.0 (https://github.com/rust-embedded/msp430?branch=rt-up#b855e444)
   Compiling quote v0.6.13
   Compiling msp430-rt-macros v0.2.0 (https://github.com/rust-embedded/msp430-rt?branch=rt-up#4b87ed0d)
   Compiling msp430fr2355-quickstart v0.1.0 (/home/william/Projects/msp430fr2355-quickstart)
warning: constant item is never used: `MAX_DCO_MUL_EXP`
  --> src/clocks.rs:10:1
   |
10 | const MAX_DCO_MUL_EXP: u8 = 10;
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: #[warn(dead_code)] on by default

warning: unused import: `interrupt`
 --> examples/blinky.rs:8:19
  |
8 | use msp430::{asm, interrupt};
  |                   ^^^^^^^^^
  |
  = note: #[warn(unused_imports)] on by default

    Finished dev [optimized + debuginfo] target(s) in 28.12s
william@xubuntu-dtrain:~/Projects/msp430fr2355-quickstart$ rustc -V
rustc 1.35.0-nightly (fbd34efb3 2019-03-26)
william@xubuntu-dtrain:~/Projects/msp430fr2355-quickstart$ xargo -V
xargo 0.3.14
cargo 1.35.0-nightly (0e35bd8af 2019-03-13)
william@xubuntu-dtrain:~/Projects/msp430fr2355-quickstart$ uname -a
Linux xubuntu-dtrain 4.15.0-66-generic #75~16.04.1-Ubuntu SMP Tue Oct 1 14:01:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
william@xubuntu-dtrain:~/Projects/msp430fr2355-quickstart$ msp430-elf-gcc --version
msp430-elf-gcc (Mitto Systems Limited - msp430-gcc 8.3.1.25) 8.3.1
Copyright (C) 2018 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

william@xubuntu-dtrain:~/Projects/msp430fr2355-quickstart$ msp430-elf-ld --version
GNU ld (Mitto Systems Limited - msp430-gcc 8.3.1.25) 2.26.20160125
Copyright (C) 2015 Free Software Foundation, Inc.
This program is free software; you may redistribute it under the terms of
the GNU General Public License version 3 or (at your option) a later version.
This program has absolutely no warranty.
william@xubuntu-dtrain:~/Projects/msp430fr2355-quickstart$ echo $PATH
/home/william/Projects/msp430-gcc-8.3.1.25_linux64/bin:/home/william/.cargo/bin:/home/william/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin
william@xubuntu-dtrain:~/Projects/msp430fr2355-quickstart$

If upgrading your toolchain doesn't fix this, I'm not sure what the problem is, I'm afraid :(...