Scatter chart by minahlee · Pull Request #375 · ZEPL/zeppelin

minahlee · 2015-03-08T05:18:26Z

This PR introduces zeppelin scatter/bubble chart.

Here is the preview.

This reverts commit 8a81e25.

…ter_chart

swkimme · 2015-03-08T05:48:20Z

Awesome! I'll test it!

On 2015년 3월 8일 (일) 14:18 minahlee notifications@github.com wrote:

This PR introduces zeppelin scatter/bubble chart.

Here is the preview.
[image: 2015-03-08 2 16 02]

https://cloud.githubusercontent.com/assets/8503346/6544654/c3a75302-c59d-11e4-99b0-3f080bc84ee4.png

You can view, comment on, or merge this pull request online at:

#375
Commit Summary

Add scatter chart

Revert "Add scatter chart"

Merge branch 'master' of https://github.com/NFLabs/zeppelin into
scatter_chart

Add scatter chart button

Remove useless 'SetPieChart' function

Add scatter chart

File Changes

A zeppelin-web/app/fonts/custom-font.eot
https://github.com/NFLabs/zeppelin/pull/375/files#diff-0 (0)

A zeppelin-web/app/fonts/custom-font.svg
https://github.com/NFLabs/zeppelin/pull/375/files#diff-1 (25)

A zeppelin-web/app/fonts/custom-font.ttf
https://github.com/NFLabs/zeppelin/pull/375/files#diff-2 (0)

A zeppelin-web/app/fonts/custom-font.woff
https://github.com/NFLabs/zeppelin/pull/375/files#diff-3 (0)

M zeppelin-web/app/index.html
https://github.com/NFLabs/zeppelin/pull/375/files#diff-4 (2)

M zeppelin-web/app/scripts/controllers/paragraph.js
https://github.com/NFLabs/zeppelin/pull/375/files#diff-5 (423)

A zeppelin-web/app/scripts/directives/popover-html-unsafe.js
https://github.com/NFLabs/zeppelin/pull/375/files#diff-6 (15)

A zeppelin-web/app/styles/custom-font.css
https://github.com/NFLabs/zeppelin/pull/375/files#diff-7 (18)

M zeppelin-web/app/styles/notebook.css
https://github.com/NFLabs/zeppelin/pull/375/files#diff-8 (9)

M zeppelin-web/app/views/paragraph.html
https://github.com/NFLabs/zeppelin/pull/375/files#diff-9 (84)

A zeppelin-web/app/views/popover-html-unsafe-popup.html
https://github.com/NFLabs/zeppelin/pull/375/files#diff-10 (8)

Patch Links:

https://github.com/NFLabs/zeppelin/pull/375.patch

https://github.com/NFLabs/zeppelin/pull/375.diff

—
Reply to this email directly or view it on GitHub
#375.

swkimme · 2015-03-09T06:12:23Z

I got some problem running this branch.

The animating feature could be the problem?

swkimme · 2015-03-10T06:59:56Z

It was my mistake! I was building old scatter_chart branch.. I tested and works great!

minahlee · 2015-03-10T07:01:39Z

Thx for the feedback! I was going to ask you how can I reproduce the error.
please let me know if another error pops up with new scatter chart branch :)

swkimme · 2015-03-10T07:29:14Z

I have a suggestion.

Currently the chart is displaying group when I hover mouse on a point.
It will be cooler if we display size, too!

minahlee · 2015-03-10T07:34:37Z

Actually that is what I wanted to do from the beginning, but I could not find solution...
I will dig into it more and add that feature in another PR if I find the way to do it!

swkimme · 2015-03-10T07:38:47Z

Then it looks good to me! But we also need to write Typescript ver. codes for #321.
I can help you if you have problem writing Typescripts.

minahlee · 2015-03-10T07:40:04Z

Ok I will merge this PR on #321 too.

corneadoug · 2015-03-10T07:41:36Z

I know how to print value instead of group :)

corneadoug · 2015-03-10T08:42:52Z

If the Size is not a valid type of value, we don't show the size

If the Size is a valid type of value, we show the Size in the tooltip

swkimme · 2015-03-10T08:59:33Z

@corneadoug
You're the best!

felixcheung · 2015-03-11T07:02:18Z

Cool - what's the best way to get test data to test this out? I see a SQL statement, so any table/SQL output would work?

corneadoug · 2015-03-11T07:06:33Z

@felixcheung You can test it with any notebook you already have.
Scatter Chart is shown as an additional button on the visualization graph switch bar, it is on the far right of that bar.

Leemoonsoo · 2015-03-11T08:05:27Z

Awesome Job! Looks great.

Can we merge it into master first and then create typescript version for #321?

swkimme · 2015-03-11T08:09:52Z

@felixcheung
Try this!

import scala.util.Random

val rdd = sc.parallelize(0 to 100).map{
  x => 
  val r = new Random
  (r.nextInt(100), r.nextInt(100), r.nextInt(4), r.nextInt(5))
}
rdd.registerTempTable("test")

swkimme · 2015-03-11T08:10:35Z

@Leemoonsoo
Sure, but at least I'd like to create an issue for that.

Leemoonsoo · 2015-03-14T11:59:46Z

While issues are created for typescript, i'm merging it!

swkimme · 2015-03-14T12:03:14Z

Let's merge it!

On 2015년 3월 14일 (토) 20:59 Lee moon soo notifications@github.com wrote:

While issues are created for typescript, i'm merging it!

—
Reply to this email directly or view it on GitHub
#375 (comment).

Scatter chart

This PR resolves https://issues.apache.org/jira/browse/ZEPPELIN-367 by synchronizing with secondary storage when reloading all notebooks into memory. Currently, existing `ZEPPELIN_NOTEBOOK_RELOAD_FROM_STORAGE` from apache/zeppelin#331 is used as a flag since these functionalities are correlated, however it can be separated into distinct flag as well. Author: Khalid Huseynov <khalidhnv@nflabs.com> Closes ZEPL#375 from khalidhuseynov/sync-on-list and squashes the following commits: e2cf5d9 [Khalid Huseynov] minor fix 878a23e [Khalid Huseynov] initial working commit

minahlee added 6 commits December 31, 2014 14:06

Add scatter chart

8a81e25

Revert "Add scatter chart"

ce077a4

This reverts commit 8a81e25.

Merge branch 'master' of https://github.com/NFLabs/zeppelin into scat…

80d1045

…ter_chart

Add scatter chart button

16f5f74

Remove useless 'SetPieChart' function

553795b

Add scatter chart

5fce509

Add Size value to scatterchart tooltip

0f9a48b

Leemoonsoo added a commit that referenced this pull request Mar 14, 2015

Merge pull request #375 from NFLabs/scatter_chart

84ab7b5

Scatter chart

Leemoonsoo merged commit 84ab7b5 into master Mar 14, 2015

Leemoonsoo deleted the scatter_chart branch March 14, 2015 14:19

Conversation

minahlee commented Mar 8, 2015

Uh oh!

swkimme commented Mar 8, 2015

https://cloud.githubusercontent.com/assets/8503346/6544654/c3a75302-c59d-11e4-99b0-3f080bc84ee4.png

Uh oh!

swkimme commented Mar 9, 2015

Uh oh!

swkimme commented Mar 10, 2015

Uh oh!

minahlee commented Mar 10, 2015

Uh oh!

swkimme commented Mar 10, 2015

Uh oh!

minahlee commented Mar 10, 2015

Uh oh!

swkimme commented Mar 10, 2015

Uh oh!

minahlee commented Mar 10, 2015

Uh oh!

corneadoug commented Mar 10, 2015

Uh oh!

corneadoug commented Mar 10, 2015

If the Size is not a valid type of value, we don't show the size

If the Size is a valid type of value, we show the Size in the tooltip

Uh oh!

swkimme commented Mar 10, 2015

Uh oh!

felixcheung commented Mar 11, 2015

Uh oh!

corneadoug commented Mar 11, 2015

Uh oh!

Leemoonsoo commented Mar 11, 2015

Uh oh!

swkimme commented Mar 11, 2015

Uh oh!

swkimme commented Mar 11, 2015

Uh oh!

Leemoonsoo commented Mar 14, 2015

Uh oh!

swkimme commented Mar 14, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants