fixed keyboard collapse on set fees form

[deregs]

Initial fix to collapse keyboard on set fees form.

[deregs]

can add this in other areas if we think this is the right approach

[kaloudis]

Did changing the input type to number-pad not offer the same functionality?

[deregs]

Did changing the input type to number-pad not offer the same functionality?

It looks like the only difference between numeric and number-pad keyboards is that number-pad doesn't have a decimal point. Here are the visual differences in keyboards.

From reading this thread, it seems that using keyboard.dismiss is the proper way to fix this.

However, I could be wrong because I only tested number-pad on an emulator since I can't run the app on my phone without a developer account. And the keyboard collapse issue is only happening on iOS, not android.

[deregs]

@kaloudis I checked everywhere else that uses numeric keyboard, and the collapse issue is not a problem because the pages are longer so they're using ScrollView. In ScrollView, tapping outside of the text boxes always collapses the keyboard.

So we can either go through with this change for the set fees form, or we can use ScrollView for this form. Do you prefer one over the other?

[kaloudis]

Good find. Let's go with ScrollView then - it can't hurt and is cleaner

[deregs]

Good find. Let's go with ScrollView then - it can't hurt and is cleaner

done

[kaloudis]

We have keyboardType="numeric" several places in the app. Do we need to apply this fix elsewhere or are they all already covered by ScrollViews?

[deregs]

We have keyboardType="numeric" several places in the app. Do we need to apply this fix elsewhere or are they all already covered by ScrollViews?

All covered by ScrollView. It's used in EditFee, OpenChannel, PaymentRequest, Receive, Send, Channel, and AddEditNode, always within a scrollview from what I see.