Skip to content

Adding amp toggle for keysends#840

Merged
kaloudis merged 3 commits intoZeusLN:masterfrom
deregs:keysend-amp-switch
Mar 4, 2022
Merged

Adding amp toggle for keysends#840
kaloudis merged 3 commits intoZeusLN:masterfrom
deregs:keysend-amp-switch

Conversation

@deregs
Copy link
Copy Markdown
Contributor

@deregs deregs commented Feb 17, 2022

Description

Relates to issue: ZEUS-832

Previously, for LND 0.13 and 0.14 nodes, the keysend page would default to sending an amp payment. This could potentially cause issues, because amp payments will fail unless they're being sent to another LND 0.13 / 0.14 node with accept-amp turned on.

This change introduces an amp toggle for keysends. The toggle will only appear if the node supports amp (meaning it's an LND 0.13 / 0.14 node).

Screenshot when toggle is disabling amp payment:

Screen Shot 2022-02-16 at 9 07 33 PM

Screenshot when toggle is enabling amp payment:

Screen Shot 2022-02-16 at 9 08 13 PM

@kaloudis
Copy link
Copy Markdown
Contributor

I think the toggle should stay above the Max parts field. Thoughts @Bosch-0?

At the very least it should be consistent with the PaymentRequest view

@deregs
Copy link
Copy Markdown
Contributor Author

deregs commented Feb 18, 2022

I think the toggle should stay above the Max parts field. Thoughts @Bosch-0?

At the very least it should be consistent with the PaymentRequest view

I agree, to remain consistent with PaymentRequest, and also users might toggle it on just to see what it is, and then they'd have to scroll all the way down to toggle it off. I made the change, and here's a screenshot for when toggle is enabling amp payment:

Screen Shot 2022-02-18 at 4 59 34 PM

@kaloudis kaloudis added this to the v0.6.1 milestone Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants