Merged
Conversation
kaloudis
reviewed
Feb 17, 2022
Contributor
|
I think the toggle should stay above the Max parts field. Thoughts @Bosch-0? At the very least it should be consistent with the |
Contributor
Author
I agree, to remain consistent with |
kaloudis
approved these changes
Mar 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Relates to issue: ZEUS-832
Previously, for LND 0.13 and 0.14 nodes, the keysend page would default to sending an amp payment. This could potentially cause issues, because amp payments will fail unless they're being sent to another LND 0.13 / 0.14 node with accept-amp turned on.
This change introduces an amp toggle for keysends. The toggle will only appear if the node supports amp (meaning it's an LND 0.13 / 0.14 node).
Screenshot when toggle is disabling amp payment:
Screenshot when toggle is enabling amp payment: