[LND] Allow spending of unconfirmed coins#956
Merged
kaloudis merged 4 commits intoZeusLN:masterfrom Apr 27, 2022
Merged
Conversation
Contributor
|
Unless you explicitly add the flag to |
Contributor
Author
Oh, I left it out by accident actually I meant to add it there, but you think that's the functionality we should go with? Only setting |
kaloudis
approved these changes
Apr 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Relates to issue: #949
Sets
spend_unconfirmedto true for the following LND routes:v1/channelsv1/channels/streamv1/transactions/v2/wallet/psbt/fundQuickly tested and it works for me, but could use more eyes on this.
This pull request is categorized as a:
Checklist
npm run tscand made sure my code compiles correctlynpm run lintand made sure my code didn’t contain any problematic patternsnpm run prettierand made sure my code is formatted correctlynpm run testand made sure all of the tests passTesting
If you added new functionality or fixed a bug, did you add new unit tests?
I have tested this PR on the following platforms (please specify OS version and phone model/VM):
I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):
Locales
Third Party Dependencies and Packages
npm installafter this PR is merged inpackage.jsonandpackage-lock.jsonhave been properly updatedOther: