Skip to content

Incorporating deadline into UART/writer interfaces in MicroZig #1017

Description

@mattnite

Quick question that popped up when using the interfaces. Is this deadline correct? It's initialised when instantiating the Reader struct, but at least for the RP2040 I'm creating these deadlines with time.deadline_in_ms() which simply adds the argument with the current time to define an absolute timestamp when the deadline elapses.

Now, given the deadline's instantiated at the very beginning and never recreated it basically becomes a no-op as it's always elapsed later down the road.

Would it make sense to instead of passing an instantiated mdf.time.Deadline pass an integer (i.e. deadline_ms) to instantiate the deadline whenever we make a call such as a in stream()?

Maybe I'm just using the API wrong...

Should this be an error I'd be more than happy to provide a separate PR handling this as it affects both the Reader and Writer.

Thanks a ton for your time.

Originally posted by @pcolladosoto in #1008

Metadata

Metadata

Assignees

No one assigned

    Labels

    driver frameworkThis issue is related to the MicroZig Driver Framework

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions